Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: templates/chromeInfo.js.tmpl

Issue 29399569: Issue 5060 - Move require into modules template, make info a module (Closed)
Left Patch Set: Created March 31, 2017, 5:44 a.m.
Right Patch Set: Improve check for require Created April 1, 2017, 1:27 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
LEFTRIGHT
1 /* This Source Code Form is subject to the terms of the Mozilla Public 1 /* This Source Code Form is subject to the terms of the Mozilla Public
2 * License, v. 2.0. If a copy of the MPL was not distributed with this 2 * License, v. 2.0. If a copy of the MPL was not distributed with this
3 * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ 3 * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
4 4
5 "use strict"; 5 "use strict";
6 6
7 let platform = "chromium"; 7 let platform = "chromium";
8 let platformVersion = null; 8 let platformVersion = null;
9 let application = null; 9 let application = null;
10 let applicationVersion; 10 let applicationVersion;
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 applicationVersion = platformVersion = "0"; 45 applicationVersion = platformVersion = "0";
46 } 46 }
47 47
48 // no additional name/version, so this is upstream Chrome 48 // no additional name/version, so this is upstream Chrome
49 if (!application) 49 if (!application)
50 { 50 {
51 application = "chrome"; 51 application = "chrome";
52 applicationVersion = platformVersion; 52 applicationVersion = platformVersion;
53 } 53 }
54 54
55 module.exports = {
56 addonName: {{ basename|json }},
57 addonVersion: {{ version|json }},
58 55
59 application, 56 exports.addonName = {{ basename|json }};
60 applicationVersion, 57 exports.addonVersion = {{ version|json }};
61 58
62 platform, 59 exports.application = application;
63 platformVersion 60 exports.applicationVersion = applicationVersion;
64 }; 61
62 exports.platform = platform;
63 exports.platformVersion = platformVersion;
LEFTRIGHT

Powered by Google App Engine
This is Rietveld