Issue 5060 - Move require into modules template, make info a module

templates/chromeInfo.js.tmpl

 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 "use strict";
 
 let platform = "chromium";
 let platformVersion = null;
 let application = null;
 let applicationVersion;
@@ skipping 34 matching lines @@
   applicationVersion = platformVersion = "0";
 }
 
 // no additional name/version, so this is upstream Chrome
 if (!application)
 {
   application = "chrome";
   applicationVersion = platformVersion;
 }
 
-module.exports = {

[Sebastian Noack, 2017/03/31 10:42:01]

Replacing module.exports isn't necessary:

  exports.addonName = {{ metadata.get('general', 'basename')|json }};
  exports.addonVersion = {{ version|json }};
  exports.application = application;
  exports.applicationVersion = applicationVersion;
  exports.platform = platform;
  exports.platformVersion = platformVersion;

[kzar, 2017/03/31 14:03:01]

Doing the assignments separately isn't necessary.

[Sebastian Noack, 2017/03/31 14:50:45]

Well, this is how we do it for every other module, except (in one or two cases)
when there is already a preexisting object whose properties we want to export.
Also that way we don't unnecessarily create two objects, discarding the first.

[kzar, 2017/03/31 15:16:54]

Done.

-  addonName: {{ basename|json }},
-  addonVersion: {{ version|json }},
 
-  application,
-  applicationVersion,
+exports.addonName = {{ basename|json }};
+exports.addonVersion = {{ version|json }};
 
-  platform,
-  platformVersion
-};
+exports.application = application;
+exports.applicationVersion = applicationVersion;
+
+exports.platform = platform;
+exports.platformVersion = platformVersion;