Issue 5060 - Move require into modules template, make info a module

templates/modules.js.tmpl

 {%- if args["module"] -%}
-if (!("require" in window))

[Sebastian Noack, 2017/03/31 10:42:01]

The assumption of the global object being "window" could be avoided:

  if (typeof require == "undefined")
  {
    require = ...

BTW, do we even have the scenario where more than one module bundle is loaded in
the same context, or shouldn't we rather avoid this anyway? Then the check
whether "require" is already defined would be unnecessary and we could also just
use "let" here.

[kzar, 2017/03/31 14:03:01]

Done.
Yes, we need that for the content scripts. Since at the very minimum there needs
to be two content scripts, one for pre and one for post load, but they share
context and we want to use modules between them.

+if (typeof require != "function")

[kzar, 2017/04/01 01:32:57]

As discussed in IRC this is safer, since if a webpage has an element of id
"require" then `require` evaluates to it and so `typeof require == "object"`, at
least by the time the postload scripts run.

[Sebastian Noack, 2017/04/01 10:02:56]

Wow, I never noticed that named elements become automatically available in the
global namespace. This is crazy. After reading up on it, I figured that IE first
introduced this mess (of course), then other browsers had to follow for
compatibility (since back in the days every website targeted IE), and eventually
it even made it into the standard:
https://www.w3.org/TR/html5/browsers.html#named-access-on-the-window-object

 {
-  window.require = function(module)
+  var require = function(module)
   {
     if (!(module in require.scopes))
     {
       let scope = {exports: {}};
       require.scopes[module] = require.modules[module](scope, scope.exports);
     }
     return require.scopes[module];
-  }
+  };
   require.modules = Object.create(null);
   require.scopes = Object.create(null);
 }
+
+{% if args["injectinfomodule"] %}
+require.modules["info"] = function(module, exports)
+{
+{% if type == "gecko-webext" %}
+{% include "geckoInfo.js.tmpl" %}
+{% elif type == "chrome" or type == "edge" %}
+{% include "chromeInfo.js.tmpl" %}
+{% endif %}
+return module.exports;
+};
+{% endif %}
+
 {%- for module_name, script in modules -%}
 require.modules[{{ module_name|json }}] = function(module, exports)
 {
 {{ script }}
 return module.exports;
 };
 
 {% endfor -%}
 {%- set modules = dict(modules) -%}
 {%- for module_name in args["autoload"] -%}
 {%- if module_name in modules -%}
 require({{ module_name|json }});
 {% endif %}
 {%- endfor -%}
 {%- else -%}
 {%- for module_name, script in modules -%}
 {{ script }}
 {% endfor -%}
 {%- endif -%}