Issue 5060 - Move require into modules template, make info a module

templates/modules.js.tmpl

 {%- if args["module"] -%}
-if (typeof require == "undefined")
+if (typeof require != "function")

[kzar, 2017/04/01 01:32:57]

As discussed in IRC this is safer, since if a webpage has an element of id
"require" then `require` evaluates to it and so `typeof require == "object"`, at
least by the time the postload scripts run.

[Sebastian Noack, 2017/04/01 10:02:56]

Wow, I never noticed that named elements become automatically available in the
global namespace. This is crazy. After reading up on it, I figured that IE first
introduced this mess (of course), then other browsers had to follow for
compatibility (since back in the days every website targeted IE), and eventually
it even made it into the standard:
https://www.w3.org/TR/html5/browsers.html#named-access-on-the-window-object

 {
-  window.require = function(module)

[Sebastian Noack, 2017/03/31 14:50:45]

This will still assume that there is a global "window" object. But I guess, if
we don't use module bundles anywhere but in the web context, that is fine.

[kzar, 2017/03/31 15:16:54]

Perhaps it matters for Firefox, can't harm to fix that anyway. Done.

[kzar, 2017/03/31 15:27:37]

(gecko-webext devbuild seems to run OK with these changes, just gave it a quick
test.)

+  var require = function(module)
   {
     if (!(module in require.scopes))
     {
       let scope = {exports: {}};
       require.scopes[module] = require.modules[module](scope, scope.exports);
     }
     return require.scopes[module];
-  }
+  };
   require.modules = Object.create(null);
   require.scopes = Object.create(null);
 }
 
+{% if args["injectinfomodule"] %}
 require.modules["info"] = function(module, exports)

[Sebastian Noack, 2017/03/31 14:50:45]

The "info" module should only be added for the background script bundle. Perhaps
introduce an option/argument (like "module" above) to indicate whether the info
module should be added.

[kzar, 2017/03/31 15:16:54]

Done.

 {
 {% if type == "gecko-webext" %}
 {% include "geckoInfo.js.tmpl" %}

[Sebastian Noack, 2017/03/31 14:50:45]

Why not just inline them here? Those templates aren't used anywhere else.
Through inlining we can avoid duplication when assigning/returning the exports.

[kzar, 2017/03/31 15:16:54]

I prefer them as separate files, I think it's easier to read than one huge
template.

 {% elif type == "chrome" or type == "edge" %}
 {% include "chromeInfo.js.tmpl" %}
 {% endif %}
 return module.exports;
 };
+{% endif %}
 
 {%- for module_name, script in modules -%}
 require.modules[{{ module_name|json }}] = function(module, exports)
 {
 {{ script }}
 return module.exports;
 };
 
 {% endfor -%}
 {%- set modules = dict(modules) -%}
 {%- for module_name in args["autoload"] -%}
 {%- if module_name in modules -%}
 require({{ module_name|json }});
 {% endif %}
 {%- endfor -%}
 {%- else -%}
 {%- for module_name, script in modules -%}
 {{ script }}
 {% endfor -%}
 {%- endif -%}