templates/modules.js.tmpl - Issue 29399569: Issue 5060 - Move require into modules template, make info a module

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: templates/modules.js.tmpl

Issue 29399569: Issue 5060 - Move require into modules template, make info a module (Closed)

Left Patch Set: Addressed more feedback Created March 31, 2017, 3:15 p.m.

Right Patch Set: Improve check for require Created April 1, 2017, 1:27 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 {%- if args["module"] -%}	1 {%- if args["module"] -%}

2 if (typeof require == "undefined")	2 if (typeof require != "function")
	kzar 2017/04/01 01:32:57 As discussed in IRC this is safer, since if a webp As discussed in IRC this is safer, since if a webpage has an element of id "require" then `require` evaluates to it and so `typeof require == "object"`, at least by the time the postload scripts run. Sebastian Noack 2017/04/01 10:02:56 Wow, I never noticed that named elements become au Show quoted text On 2017/04/01 01:32:57, kzar wrote: > As discussed in IRC this is safer, since if a webpage has an element of id > "require" then `require` evaluates to it and so `typeof require == "object"`, at > least by the time the postload scripts run. Wow, I never noticed that named elements become automatically available in the global namespace. This is crazy. After reading up on it, I figured that IE first introduced this mess (of course), then other browsers had to follow for compatibility (since back in the days every website targeted IE), and eventually it even made it into the standard: https://www.w3.org/TR/html5/browsers.html#named-access-on-the-window-object
3 {	3 {

4 var require = function(module)	4 var require = function(module)

5 {	5 {

6 if (!(module in require.scopes))	6 if (!(module in require.scopes))

7 {	7 {

8 let scope = {exports: {}};	8 let scope = {exports: {}};

9 require.scopes[module] = require.modules[module](scope, scope.exports);	9 require.scopes[module] = require.modules[module](scope, scope.exports);

10 }	10 }

11 return require.scopes[module];	11 return require.scopes[module];

12 };	12 };

(...skipping 25 matching lines...) Expand all Loading...
38 {%- for module_name in args["autoload"] -%}	38 {%- for module_name in args["autoload"] -%}

39 {%- if module_name in modules -%}	39 {%- if module_name in modules -%}

40 require({{ module_name\|json }});	40 require({{ module_name\|json }});

41 {% endif %}	41 {% endif %}

42 {%- endfor -%}	42 {%- endfor -%}

43 {%- else -%}	43 {%- else -%}

44 {%- for module_name, script in modules -%}	44 {%- for module_name, script in modules -%}

45 {{ script }}	45 {{ script }}

46 {% endfor -%}	46 {% endfor -%}

47 {%- endif -%}	47 {%- endif -%}

LEFT	RIGHT