Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(109)

Issue 29399602: Issue 5079 - Export ElemHideEmulation and splitSelector if possible (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 11 months ago by kzar
Modified:
2 years, 10 months ago
Reviewers:
Wladimir Palant
CC:
Sebastian Noack
Visibility:
Public.

Description

Issue 5079 - Export ElemHideEmulation and splitSelector if possible

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/content/elemHideEmulation.js View 1 chunk +6 lines, -0 lines 1 comment Download

Messages

Total messages: 2
kzar
Patch Set 1
2 years, 11 months ago (2017-03-31 07:39:09 UTC) #1
kzar
2 years, 10 months ago (2017-04-03 07:43:57 UTC) #2
https://codereview.adblockplus.org/29399602/diff/29399603/chrome/content/elem...
File chrome/content/elemHideEmulation.js (right):

https://codereview.adblockplus.org/29399602/diff/29399603/chrome/content/elem...
chrome/content/elemHideEmulation.js:169: if (typeof exports != "undefined")
Yes, potentially undeclared variables in content scripts again! I can't see how
else to do it though, since both exports and an element will have the type
"object". Also we're running this script in preload, so before that becomes a
problem. Also adding properties to the element which the page can't access
anyway doesn't seem to be a problem to me.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5