libadblockplus-android-webviewapp/src/org/adblockplus/libadblockplus/android/webviewapp/Application.java - Issue 29399749: Issue 5081 - Make libadblockplus-android users supply the application and applicationVersion parame…

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: libadblockplus-android-webviewapp/src/org/adblockplus/libadblockplus/android/webviewapp/Application.java

Issue 29399749: Issue 5081 - Make libadblockplus-android users supply the application and applicationVersion parame… (Closed)

Patch Set: Created March 31, 2017, 1:28 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

« libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockHelper.java ('K') | « libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockHelper.java ('k') | libadblockplus-android/src/org/adblockplus/libadblockplus/AppInfo.java » ('j') | libadblockplus-android/src/org/adblockplus/libadblockplus/android/AdblockEngine.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * This file is part of Adblock Plus <https://adblockplus.org/>,	2 * This file is part of Adblock Plus <https://adblockplus.org/>,

3 * Copyright (C) 2006-2016 Eyeo GmbH	3 * Copyright (C) 2006-2016 Eyeo GmbH

4 *	4 *

5 * Adblock Plus is free software: you can redistribute it and/or modify	5 * Adblock Plus is free software: you can redistribute it and/or modify

6 * it under the terms of the GNU General Public License version 3 as	6 * it under the terms of the GNU General Public License version 3 as

7 * published by the Free Software Foundation.	7 * published by the Free Software Foundation.

8 *	8 *

9 * Adblock Plus is distributed in the hope that it will be useful,	9 * Adblock Plus is distributed in the hope that it will be useful,

10 * but WITHOUT ANY WARRANTY; without even the implied warranty of	10 * but WITHOUT ANY WARRANTY; without even the implied warranty of

(...skipping 27 matching lines...) Expand all Loading...
38	38

39 // provide preloaded subscriptions	39 // provide preloaded subscriptions

40 Map<String, Integer> map = new HashMap<String, Integer>();	40 Map<String, Integer> map = new HashMap<String, Integer>();

41 map.put(AndroidWebRequestResourceWrapper.EASYLIST, R.raw.easylist_min);	41 map.put(AndroidWebRequestResourceWrapper.EASYLIST, R.raw.easylist_min);

42 map.put(AndroidWebRequestResourceWrapper.EASYLIST_CHINESE, R.raw.easylist_mi n);	42 map.put(AndroidWebRequestResourceWrapper.EASYLIST_CHINESE, R.raw.easylist_mi n);

43 map.put(AndroidWebRequestResourceWrapper.ACCEPTABLE_ADS, R.raw.exceptionrule s_minimal);	43 map.put(AndroidWebRequestResourceWrapper.ACCEPTABLE_ADS, R.raw.exceptionrule s_minimal);

44	44

45 AdblockHelper	45 AdblockHelper

46 .get()	46 .get()

47 .init(this, basePath, true, AdblockHelper.PREFERENCE_NAME)	47 .init(this, basePath, true, AdblockHelper.PREFERENCE_NAME)

48 .preloadSubscriptions(AdblockHelper.PRELOAD_PREFERENCE_NAME, map);	48 .preloadSubscriptions(AdblockHelper.PRELOAD_PREFERENCE_NAME, map)

	49 .setApplication(getPackageName())

	50 .setApplicationVersion("app.version");
	sergei 2017/03/31 13:49:09 is "app.version" a correct value? I thought the ex is "app.version" a correct value? I thought the expected format is a sequence of numbers. anton 2017/03/31 13:52:25 it accepts any value as it's just a string Show quoted text On 2017/03/31 13:49:09, sergei wrote: > is "app.version" a correct value? I thought the expected format is a sequence of > numbers. it accepts any value as it's just a string sergei 2017/03/31 14:01:52 Felix, what about server side and statistics scrip Show quoted text On 2017/03/31 13:52:25, anton wrote: > On 2017/03/31 13:49:09, sergei wrote: > > is "app.version" a correct value? I thought the expected format is a sequence > of > > numbers. > > it accepts any value as it's just a string Felix, what about server side and statistics script? diegocarloslima 2017/03/31 14:07:14 It would be a more intuitive example here to provi It would be a more intuitive example here to provide a number instead of a string anton 2017/03/31 14:16:08 it's just an example. it's up to app developer to Show quoted text On 2017/03/31 14:07:14, diegocarloslima wrote: > It would be a more intuitive example here to provide a number instead of a > string it's just an example. it's up to app developer to decide in what format he should pass it or up to us not to let him pass invalid values.
49 }	51 }

50 }	52 }

OLD	NEW