Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: libadblockplus-android-webviewapp/src/org/adblockplus/libadblockplus/android/webviewapp/Application.java

Issue 29399749: Issue 5081 - Make libadblockplus-android users supply the application and applicationVersion parame… (Closed)
Left Patch Set: Created March 31, 2017, 1:28 p.m.
Right Patch Set: application/-Version are required now Created March 31, 2017, 3:09 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2016 Eyeo GmbH 3 * Copyright (C) 2006-2016 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 26 matching lines...) Expand all
37 String basePath = getDir(AdblockEngine.BASE_PATH_DIRECTORY, Context.MODE_PRI VATE).getAbsolutePath(); 37 String basePath = getDir(AdblockEngine.BASE_PATH_DIRECTORY, Context.MODE_PRI VATE).getAbsolutePath();
38 38
39 // provide preloaded subscriptions 39 // provide preloaded subscriptions
40 Map<String, Integer> map = new HashMap<String, Integer>(); 40 Map<String, Integer> map = new HashMap<String, Integer>();
41 map.put(AndroidWebRequestResourceWrapper.EASYLIST, R.raw.easylist_min); 41 map.put(AndroidWebRequestResourceWrapper.EASYLIST, R.raw.easylist_min);
42 map.put(AndroidWebRequestResourceWrapper.EASYLIST_CHINESE, R.raw.easylist_mi n); 42 map.put(AndroidWebRequestResourceWrapper.EASYLIST_CHINESE, R.raw.easylist_mi n);
43 map.put(AndroidWebRequestResourceWrapper.ACCEPTABLE_ADS, R.raw.exceptionrule s_minimal); 43 map.put(AndroidWebRequestResourceWrapper.ACCEPTABLE_ADS, R.raw.exceptionrule s_minimal);
44 44
45 AdblockHelper 45 AdblockHelper
46 .get() 46 .get()
47 .init(this, basePath, true, AdblockHelper.PREFERENCE_NAME) 47 .init(this, basePath, true, AdblockHelper.PREFERENCE_NAME, getPackageName( ), "app.version")
48 .preloadSubscriptions(AdblockHelper.PRELOAD_PREFERENCE_NAME, map) 48 .preloadSubscriptions(AdblockHelper.PRELOAD_PREFERENCE_NAME, map);
49 .setApplication(getPackageName())
50 .setApplicationVersion("app.version");
sergei 2017/03/31 13:49:09 is "app.version" a correct value? I thought the ex
anton 2017/03/31 13:52:25 it accepts any value as it's just a string
sergei 2017/03/31 14:01:52 Felix, what about server side and statistics scrip
diegocarloslima 2017/03/31 14:07:14 It would be a more intuitive example here to provi
anton 2017/03/31 14:16:08 it's just an example. it's up to app developer to
51 } 49 }
52 } 50 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld