Issue 5081 - Make libadblockplus-android users supply the application and applicationVersion parame…

libadblockplus-android-webviewapp/src/org/adblockplus/libadblockplus/android/webviewapp/Application.java

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 26 matching lines @@
     String basePath = getDir(AdblockEngine.BASE_PATH_DIRECTORY, Context.MODE_PRIVATE).getAbsolutePath();
 
     // provide preloaded subscriptions
     Map<String, Integer> map = new HashMap<String, Integer>();
     map.put(AndroidWebRequestResourceWrapper.EASYLIST, R.raw.easylist_min);
     map.put(AndroidWebRequestResourceWrapper.EASYLIST_CHINESE, R.raw.easylist_min);
     map.put(AndroidWebRequestResourceWrapper.ACCEPTABLE_ADS, R.raw.exceptionrules_minimal);
 
     AdblockHelper
       .get()
-      .init(this, basePath, true, AdblockHelper.PREFERENCE_NAME)
-      .preloadSubscriptions(AdblockHelper.PRELOAD_PREFERENCE_NAME, map)
-      .setApplication(getPackageName())
-      .setApplicationVersion("app.version");

[sergei, 2017/03/31 13:49:09]

is "app.version" a correct value? I thought the expected format is a sequence of
numbers.

[anton, 2017/03/31 13:52:25]

it accepts any value as it's just a string

[sergei, 2017/03/31 14:01:52]

Felix, what about server side and statistics script?

[diegocarloslima, 2017/03/31 14:07:14]

It would be a more intuitive example here to provide a number instead of a
string

[anton, 2017/03/31 14:16:08]

it's just an example. it's up to app developer to decide in what format he
should pass it or up to us not to let him pass invalid values.

+      .init(this, basePath, true, AdblockHelper.PREFERENCE_NAME, getPackageName(), "app.version")
+      .preloadSubscriptions(AdblockHelper.PRELOAD_PREFERENCE_NAME, map);
   }
 }