Issue 5088 - Remove code duplicate for refresh subscriptions

libadblockplus-android/src/org/adblockplus/libadblockplus/android/AdblockEngine.java

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 24 matching lines @@
 import org.adblockplus.libadblockplus.JsEngine;
 import org.adblockplus.libadblockplus.JsValue;
 import org.adblockplus.libadblockplus.LogSystem;
 import org.adblockplus.libadblockplus.ShowNotificationCallback;
 import org.adblockplus.libadblockplus.Subscription;
 import org.adblockplus.libadblockplus.UpdateAvailableCallback;
 import org.adblockplus.libadblockplus.UpdateCheckDoneCallback;
 import org.adblockplus.libadblockplus.WebRequest;
 
 import android.content.Context;
-import android.content.pm.PackageInfo;
-import android.content.pm.PackageManager.NameNotFoundException;
 import android.os.Build.VERSION;
 import android.os.Handler;
 import android.os.Looper;
 import android.util.Log;
 
 public final class AdblockEngine
 {
   // default base path to store subscription files in android app
   public static final String BASE_PATH_DIRECTORY = "adblock";
 
@@ skipping 198 matching lines @@
 
     private final Handler handler = new Handler(Looper.getMainLooper());
 
     private final Runnable forceUpdateRunnable = new Runnable()
     {
       public void run() {
         // Filter Engine can be already disposed
         if (filterEngine != null)
         {
           Log.d(TAG, "Force update subscriptions");
-          List<Subscription> subscriptions = filterEngine.getListedSubscriptions();
-          for (Subscription eachSubscription : subscriptions)
-          {
-            try
-            {
-              eachSubscription.updateFilters();
-            }
-            finally
-            {
-              eachSubscription.dispose();
-            }
-          }
+          AdblockEngine.this.updateSubscriptions();
         }
       }
     };
 
     @Override
     public void onIntercepted(String url, int resourceId)
     {
       // we need to force update subscriptions ASAP after preloaded one is returned
       // but we should note that multiple interceptions (for main easylist and AA) and force update once only
 
@@ skipping 201 matching lines @@
           sub.addToList();
         }
         finally
         {
           sub.dispose();
         }
       }
     }
   }
 
-  public void refreshSubscriptions()
+  public void updateSubscriptions()
   {
     for (final Subscription s : this.filterEngine.getListedSubscriptions())
     {
       try
       {
         s.updateFilters();
       }
       finally
       {
         s.dispose();
@@ skipping 218 matching lines @@
   public void setWhitelistedDomains(List<String> domains)
   {
     this.whitelistedDomains = domains;
   }
 
   public List<String> getWhitelistedDomains()
   {
     return whitelistedDomains;
   }
 }