Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29401571: Issue 5086 - Add webrtc request type (Closed)

Created:
April 3, 2017, 8:22 a.m. by kzar
Modified:
April 8, 2017, 7:38 a.m.
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

Issue 5086 - Add webrtc request type

Patch Set 1 #

Patch Set 2 : Steal unit tests from emscripten branch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M lib/filterClasses.js View 1 chunk +1 line, -0 lines 0 comments Download
M test/regexpFilters_matching.js View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6
kzar
Patch Set 1
April 3, 2017, 8:24 a.m. (2017-04-03 08:24:26 UTC) #1
Wladimir Palant
LGTM This change needs to land on Emscripten branch as well, I can take care ...
April 4, 2017, 1:14 p.m. (2017-04-04 13:14:42 UTC) #2
Wladimir Palant
Actually, you forgot to add it to the tests.
April 4, 2017, 1:32 p.m. (2017-04-04 13:32:25 UTC) #3
kzar
On 2017/04/04 13:32:25, Wladimir Palant wrote: > Actually, you forgot to add it to the ...
April 5, 2017, 4:01 a.m. (2017-04-05 04:01:42 UTC) #4
kzar
Patch Set 2 : Steal unit tests from emscripten branch
April 7, 2017, 10:08 a.m. (2017-04-07 10:08:57 UTC) #5
Wladimir Palant
April 8, 2017, 6:53 a.m. (2017-04-08 06:53:13 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld