dependencies - Issue 29401596: Issue 5094 - Implement support for :has() in chrome extension

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: dependencies

Issue 29401596: Issue 5094 - Implement support for :has() in chrome extension (Closed) Base URL: https://hg.adblockplus.org/adblockpluschrome/

Left Patch Set: Rebased. With the proper revision in dependencies. Created June 14, 2017, 2:21 a.m.

Right Patch Set: Update dependencies to the latest. Created June 19, 2017, 2:12 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 _root = hg:https://hg.adblockplus.org/ git:https://github.com/adblockplus/	1 _root = hg:https://hg.adblockplus.org/ git:https://github.com/adblockplus/

2 _self = buildtools/ensure_dependencies.py	2 _self = buildtools/ensure_dependencies.py

3 buildtools = buildtools hg:4276509ccff9 git:3eb4cc7	3 buildtools = buildtools hg:4276509ccff9 git:3eb4cc7

4 adblockplus = adblockplus hg:c8ec667756d3 git:9a42447	4 adblockplus = adblockplus hg:c8ec667756d3 git:9a42447

5 adblockpluscore = adblockpluscore hg:d3cd9c1c85e4 git:57a2198	5 adblockpluscore = adblockpluscore hg:d30ba414cc3d git:7ff039d
kzar 2017/06/14 10:20:30 Quite a lot of other adblockpluscore commits were Quite a lot of other adblockpluscore commits were included in this dependency update, but those aren't mentioned in the issue description. Could you go through all those commits and check if any code that adblockpluschrome uses was changed? If you find any list them in the description and also add instructions explaining how to test the functionality those changes touch in the "Hints for testers" section. That way the QA guys know what to test so that we avoid regressions, since sometimes a dependency update will break something seemingly completely unrelated. (Even if you don't find any relevant files were changed by those other commits please still mention that there were other unrelated changes, and that you checked through them in the issue.) hub 2017/06/14 15:49:27 good point. I have added them to the issue dscript Show quoted text On 2017/06/14 10:20:30, kzar wrote: > Quite a lot of other adblockpluscore commits were included in this dependency > update, but those aren't mentioned in the issue description. Could you go > through all those commits and check if any code that adblockpluschrome uses was > changed? > > If you find any list them in the description and also add instructions > explaining how to test the functionality those changes touch in the "Hints for > testers" section. That way the QA guys know what to test so that we avoid > regressions, since sometimes a dependency update will break something seemingly > completely unrelated. > > (Even if you don't find any relevant files were changed by those other commits > please still mention that there were other unrelated changes, and that you > checked through them in the issue.) good point. I have added them to the issue dscription.
6 adblockplusui = adblockplusui hg:5503e0f10d7b git:523b73d	6 adblockplusui = adblockplusui hg:5503e0f10d7b git:523b73d

LEFT	RIGHT