includes/navbar.tmpl - Issue 29401619: Issue 4963 - Wrong size used for text logo on acceptableads.com

Delta Between Two Patch Sets: includes/navbar.tmpl

Issue 29401619: Issue 4963 - Wrong size used for text logo on acceptableads.com (Closed) Base URL: https://hg.adblockplus.org/web.acceptableads.com

Left Patch Set: Addressed comments Created May 22, 2017, 7:08 p.m.

Right Patch Set: Changed non-space to word-spacing Created June 14, 2017, 12:02 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 {#	1 {#

2 # This file is part of acceptableads.org.	2 # This file is part of acceptableads.org.

3 # Copyright (C) 2016 Eyeo GmbH	3 # Copyright (C) 2016 Eyeo GmbH

4 #	4 #

5 # acceptableads.org is free software: you can redistribute it and/or modify	5 # acceptableads.org is free software: you can redistribute it and/or modify

6 # it under the terms of the GNU General Public License as published by	6 # it under the terms of the GNU General Public License as published by

7 # the Free Software Foundation, either version 3 of the License, or	7 # the Free Software Foundation, either version 3 of the License, or

8 # (at your option) any later version.	8 # (at your option) any later version.

9 #	9 #

10 # acceptableads.org is distributed in the hope that it will be useful,	10 # acceptableads.org is distributed in the hope that it will be useful,

11 # but WITHOUT ANY WARRANTY; without even the implied warranty of	11 # but WITHOUT ANY WARRANTY; without even the implied warranty of

12 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the	12 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the

13 # GNU General Public License for more details.	13 # GNU General Public License for more details.

14 #	14 #

15 # You should have received a copy of the GNU General Public License	15 # You should have received a copy of the GNU General Public License

16 # along with acceptableads.org. If not, see <http://www.gnu.org/licenses/>.	16 # along with acceptableads.org. If not, see <http://www.gnu.org/licenses/>.

17 #}	17 #}

18	18

19 <header id="navbar">	19 <header id="navbar">

20 <h1 class="site-title">{{ "index" \| linkify(id="navbar-logo") }}Acceptable<spa n class="non-space"> </span><strong>Ads</strong></a></h1>	20 <h1 class="site-title">{{ "index" \| linkify() }}Acceptable <strong>Ads</strong ></a></h1>
saroyanm 2017/06/01 13:09:54 What about ?: <h1 class="site-title"> <span>Acc What about ?: <h1 class="site-title"> <span>Acceptable</span><strong>Ads</strong> </h1> .site-title { font-size: 0px; } .site-title > * { font-size: 17px; } See discussion: https://stackoverflow.com/questions/5078239/how-to-remove-the-space-between-i... juliandoucette 2017/06/07 15:42:52 I tried that already and I didn't think it looked Show quoted text On 2017/06/01 13:09:54, saroyanm wrote: > What about ?: > > <h1 class="site-title"> > <span>Acceptable</span><strong>Ads</strong> > </h1> > > .site-title > { > font-size: 0px; > } > .site-title > * > { > font-size: 17px; > } > > See discussion: > https://stackoverflow.com/questions/5078239/how-to-remove-the-space-between-i... I tried that already and I didn't think it looked right. The 1px space is necessary IMO. Please look yourself and tell me if you think otherwise. saroyanm 2017/06/13 10:31:03 I thought you were fighting the space in between, Show quoted text On 2017/06/07 15:42:52, juliandoucette wrote: > On 2017/06/01 13:09:54, saroyanm wrote: > > What about ?: > > > > <h1 class="site-title"> > > <span>Acceptable</span><strong>Ads</strong> > > </h1> > > > > .site-title > > { > > font-size: 0px; > > } > > .site-title > * > > { > > font-size: 17px; > > } > > > > See discussion: > > > https://stackoverflow.com/questions/5078239/how-to-remove-the-space-between-i... > > I tried that already and I didn't think it looked right. The 1px space is > necessary IMO. Please look yourself and tell me if you think otherwise. I thought you were fighting the space in between, What about: .site-title strong { margin: 0px 1px; } I'm not really sure if we will need additional element to achieve the result. juliandoucette 2017/06/13 11:17:09 Fuck me... You're right :D - Thank you! Show quoted text > I thought you were fighting the space in between, > > What about: > .site-title strong > { > margin: 0px 1px; > } > > I'm not really sure if we will need additional element to achieve the result. Fuck me... You're right :D - Thank you! juliandoucette 2017/06/13 11:59:30 I have to backpedal here... Actually, I am fighti Show quoted text > I thought you were fighting the space in between, > > What about: > .site-title strong > { > margin: 0px 1px; > } > > I'm not really sure if we will need additional element to achieve the result. I have to backpedal here... Actually, I am fighting the space in between. "Acceptable Ads" is two words. I know that we tested one screen reader - but that doesn't confirm that this works as expected using others. Or that search engines will interpret this correctly. saroyanm 2017/06/13 12:28:20 Acknowledged. What about using "word-spacing" pro Show quoted text On 2017/06/13 11:59:30, juliandoucette wrote: > > I thought you were fighting the space in between, > > > > What about: > > .site-title strong > > { > > margin: 0px 1px; > > } > > > > I'm not really sure if we will need additional element to achieve the result. > > I have to backpedal here... > > Actually, I am fighting the space in between. "Acceptable Ads" is two words. I > know that we tested one screen reader - but that doesn't confirm that this works > as expected using others. Or that search engines will interpret this correctly. Acknowledged. What about using "word-spacing" property instead ? juliandoucette 2017/06/14 12:05:33 Done. Good idea :) Show quoted text > Acknowledged. > > What about using "word-spacing" property instead ? Done. Good idea :)
21 <a class="sr-only" href="#main">{{ 'Skip to main content' \| translate('skip-to -main-content', 'Skip to main content link label (screen reader only)') }}</a>	21 <a class="sr-only" href="#main">{{ 'Skip to main content' \| translate('skip-to -main-content', 'Skip to main content link label (screen reader only)') }}</a>

22 <a class="sr-only" href="#sidebar">{{ 'Skip to main navigation' \| translate('s kip-to-main-navigation', 'Skip to main navigation link label (screen reader only )') }}</a>	22 <a class="sr-only" href="#sidebar">{{ 'Skip to main navigation' \| translate('s kip-to-main-navigation', 'Skip to main navigation link label (screen reader only )') }}</a>

23 </header>	23 </header>

LEFT	RIGHT