Delta Between Two Patch Sets: static/scss/layout/_navbar.scss
Issue 29401619:
Issue 4963 - Wrong size used for text logo on acceptableads.com (Closed)
Base URL: https://hg.adblockplus.org/web.acceptableads.com
Left Patch Set: Addressed comments
Created May 22, 2017, 7:08 p.m.
Right Patch Set: Changed non-space to word-spacing
Created June 14, 2017, 12:02 p.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« static/css/main.css ('K')
|
« static/css/main.css ('k')
|
static/scss/layout/_sidebar.scss » ('j')
|
no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| LEFT | RIGHT |
|---|---|
| 1 // This file is part of acceptableads.org. | 1 // This file is part of acceptableads.org. |
| 2 // Copyright (C) 2016 Eyeo GmbH | 2 // Copyright (C) 2016 Eyeo GmbH |
| 3 // | 3 // |
| 4 // acceptableads.org is free software: you can redistribute it and/or modify | 4 // acceptableads.org is free software: you can redistribute it and/or modify |
| 5 // it under the terms of the GNU General Public License as published by | 5 // it under the terms of the GNU General Public License as published by |
| 6 // the Free Software Foundation, either version 3 of the License, or | 6 // the Free Software Foundation, either version 3 of the License, or |
| 7 // (at your option) any later version. | 7 // (at your option) any later version. |
| 8 // | 8 // |
| 9 // acceptableads.org is distributed in the hope that it will be useful, | 9 // acceptableads.org is distributed in the hope that it will be useful, |
| 10 // but WITHOUT ANY WARRANTY; without even the implied warranty of | 10 // but WITHOUT ANY WARRANTY; without even the implied warranty of |
| (...skipping 24 matching lines...) Expand all Loading... | |
| 35 z-index: 1; | 35 z-index: 1; |
| 36 top: 0; | 36 top: 0; |
| 37 left: 0; | 37 left: 0; |
| 38 } | 38 } |
| 39 | 39 |
| 40 .site-title | 40 .site-title |
| 41 { | 41 { |
| 42 margin: 0; | 42 margin: 0; |
| 43 font-size: 17px; | 43 font-size: 17px; |
| 44 line-height: 64px; | 44 line-height: 64px; |
| 45 word-spacing: -2px; | |
| 45 } | 46 } |
| 46 | 47 |
| 47 .site-title a | 48 .site-title a |
| 48 { | 49 { |
| 49 color: $primary-fg; | 50 color: $primary-fg; |
| 50 text-decoration: none; | 51 text-decoration: none; |
| 51 font-weight: 300; | 52 font-weight: 300; |
| 52 } | 53 } |
| 53 | 54 |
| 54 .site-title .non-space | |
| 55 { | |
| 56 display: inline-block; | |
| 57 width: 1px; | |
| 58 } | |
| 59 | |
| 60 .site-title a strong | 55 .site-title a strong |
| 61 { | 56 { |
| 62 font-weight: 400; | 57 font-weight: 400; |
| 63 } | 58 } |
| 64 | 59 |
| 65 @media(min-width: $sidebar-breakpoint-x) | 60 @media(min-width: $sidebar-breakpoint-x) |
| 66 { | 61 { |
| 67 html[dir="rtl"] #navbar-logo | 62 html[dir="rtl"] .site-title |
|
saroyanm
2017/06/01 13:09:54
"#navbar-logo" Item is a duplication, let's use ".
juliandoucette
2017/06/07 15:42:52
Done.
Good find.
| |
| 68 { | 63 { |
| 69 margin-right: $sidebar-width; | 64 margin-right: $sidebar-width; |
| 70 } | 65 } |
| 71 html[dir="ltr"] #navbar-logo | 66 html[dir="ltr"] .site-title |
| 72 { | 67 { |
| 73 margin-left: $sidebar-width; | 68 margin-left: $sidebar-width; |
| 74 } | 69 } |
| 75 } | 70 } |
| 76 | 71 |
| 77 @media(max-width: $sidebar-breakpoint-x - 1) | 72 @media(max-width: $sidebar-breakpoint-x - 1) |
| 78 { | 73 { |
| 79 .js #navbar | 74 .js #navbar |
| 80 { | 75 { |
| 81 display: none; | 76 display: none; |
| 82 } | 77 } |
| 83 } | 78 } |
| LEFT | RIGHT |
« static/css/main.css ('k')
|
static/scss/layout/_sidebar.scss » ('j')
|
Toggle Intra-line Diffs ('i')
|
Expand Comments ('e')
|
Collapse Comments ('c')
|
Toggle Comments ('s')
