includes/navbar.tmpl - Issue 29401619: Issue 4963 - Wrong size used for text logo on acceptableads.com

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: includes/navbar.tmpl

Issue 29401619: Issue 4963 - Wrong size used for text logo on acceptableads.com (Closed) Base URL: https://hg.adblockplus.org/web.acceptableads.com

Patch Set: Created April 3, 2017, 9:39 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: includes/navbar.tmpl

===================================================================

--- a/includes/navbar.tmpl

+++ b/includes/navbar.tmpl

@@ -12,15 +12,12 @@

# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the

# GNU General Public License for more details.

# You should have received a copy of the GNU General Public License

# along with acceptableads.org. If not, see <http://www.gnu.org/licenses/>.

- {{ "index" | linkify(id="navbar-logo") }}

- <h1 class="sr-only">{{ title | translate("document-title", "Document title") }}</h1>

- <img src="/img/png/logo-black.png" srcset="/img/png/logo-black.png, /img/svg/logo-black.svg 2x" aria-hidden="true">

saroyanm 2017/04/28 10:19:48 We still have this image in sidebar to be shown on

juliandoucette 2017/05/22 19:18:33 Acknowledged. I would have to re-write a signific

saroyanm 2017/06/13 10:31:03 Do we have an issue already ?

juliandoucette 2017/06/13 11:17:09 Not yet. I will create one before I upload the nex

juliandoucette 2017/06/14 12:15:20 Done. https://issues.adblockplus.org/ticket/5319

- </a>

+ <h1>{{ "index" | linkify(id="navbar-logo") }}Acceptable <strong>Ads</strong></a></h1>

<a class="sr-only" href="#main">{{ 'Skip to main content' | translate('skip-to-main-content', 'Skip to main content link label (screen reader only)') }}</a>

<a class="sr-only" href="#sidebar">{{ 'Skip to main navigation' | translate('skip-to-main-navigation', 'Skip to main navigation link label (screen reader only)') }}</a>

</header>

« no previous file with comments | « no previous file | static/css/main.css » ('j') | static/scss/layout/_navbar.scss » ('J')