Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: includes/navbar.tmpl

Issue 29401619: Issue 4963 - Wrong size used for text logo on acceptableads.com (Closed) Base URL: https://hg.adblockplus.org/web.acceptableads.com
Patch Set: Addressed comments Created May 22, 2017, 7:08 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | includes/sidebar.tmpl » ('j') | static/scss/layout/_navbar.scss » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: includes/navbar.tmpl
===================================================================
--- a/includes/navbar.tmpl
+++ b/includes/navbar.tmpl
@@ -12,15 +12,12 @@
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with acceptableads.org. If not, see <http://www.gnu.org/licenses/>.
#}
<header id="navbar">
- {{ "index" | linkify(id="navbar-logo") }}
- <h1 class="sr-only">{{ title | translate("document-title", "Document title") }}</h1>
- <img src="/img/png/logo-black.png" srcset="/img/png/logo-black.png, /img/svg/logo-black.svg 2x" aria-hidden="true">
- </a>
+ <h1 class="site-title">{{ "index" | linkify(id="navbar-logo") }}Acceptable<span class="non-space"> </span><strong>Ads</strong></a></h1>
saroyanm 2017/06/01 13:09:54 What about ?: <h1 class="site-title"> <span>Acc
juliandoucette 2017/06/07 15:42:52 I tried that already and I didn't think it looked
saroyanm 2017/06/13 10:31:03 I thought you were fighting the space in between,
juliandoucette 2017/06/13 11:17:09 Fuck me... You're right :D - Thank you!
juliandoucette 2017/06/13 11:59:30 I have to backpedal here... Actually, I am fighti
saroyanm 2017/06/13 12:28:20 Acknowledged. What about using "word-spacing" pro
juliandoucette 2017/06/14 12:05:33 Done. Good idea :)
<a class="sr-only" href="#main">{{ 'Skip to main content' | translate('skip-to-main-content', 'Skip to main content link label (screen reader only)') }}</a>
<a class="sr-only" href="#sidebar">{{ 'Skip to main navigation' | translate('skip-to-main-navigation', 'Skip to main navigation link label (screen reader only)') }}</a>
</header>
« no previous file with comments | « no previous file | includes/sidebar.tmpl » ('j') | static/scss/layout/_navbar.scss » ('J')

Powered by Google App Engine
This is Rietveld