Issue 4963 - Wrong size used for text logo on acceptableads.com

static/scss/layout/_sidebar.scss

Index: static/scss/layout/_sidebar.scss
===================================================================
--- a/static/scss/layout/_sidebar.scss
+++ b/static/scss/layout/_sidebar.scss
@@ -32,24 +32,16 @@
     text-align: inherit;
   }
 
   li::before
   {
     @extend .unstyle-list;
   }
 
-  a,
-  a%active
-  {
-    display: block;
-    text-decoration: none;
-    color: inherit;
-  }
-
   // #sidebar-brank blocks
   // #sidebar-logo is visible on desktop
   // #sidebar-open, #sidebar-close, and #sidebar-tittle are visible on mobile
 
   #sidebar-brand
   {
     height: $lg;
     line-height: $lg;
@@ -67,17 +59,17 @@
       width: $md;
       height: $md;
       vertical-align: middle;
     }
   }
 
   #sidebar-open,
   #sidebar-close,
-  #sidebar-title
+  .site-title
   {
     display: none;
   }
 
   #sidebar-close img
   {
     width: 20px;
     height: 20px;
@@ -85,16 +77,27 @@
 
   #sidebar-open img
   {
     width: 36px;
     height: 18px;
   }
 }
 
+#sidebar-menus

[juliandoucette, 2017/05/22 19:18:33]

I moved this from #sidebar to #sidebar-menus to avoid overriding it in #sidebar
.site-title.

+{
+  a,
+  a%active
+  {
+    display: block;
+    text-decoration: none;
+    color: inherit;
+  }
+}
+
 // Positioning the sidebar on desktop
 @media(min-width: $sidebar-breakpoint-x)
 {
   // since the primary navigation collapses only when javascript is enabled
   // we must position this absolute by default so that it can scroll
   #sidebar
   {
     position: absolute;
@@ -158,17 +161,17 @@
   html[dir="rtl"].js #sidebar
   {
     text-align: right;
   }
 
   #sidebar
   {
     // show sidebar navbar title and open button by default
-    #sidebar-title,
+    .site-title,
     #sidebar-open
     {
       display: block;
     }
 
     // Toggle open/close buttons
     &.open
     {
@@ -187,63 +190,56 @@
     #sidebar-brand
     {
       background-color: $inverted-fg;
     }
 
     #sidebar-open,
     #sidebar-close,
     #sidebar-logo,
-    #sidebar-title
+    .site-title
     {
       padding: 0 $sm;
     }
 
     #sidebar-open,
     #sidebar-close,
-    #sidebar-title

[saroyanm, 2017/06/01 13:09:54]

Seems like we are not referring to the item by it's ID anymore, I don't think we
need to keep the element Identifiable anymore.

[juliandoucette, 2017/06/07 15:42:52]

Done.

Good find.

+    .site-title
     {
       height: $lg;
       line-height: $lg;
     }
 
     #sidebar-open,
     #sidebar-close
     {
       width: $lg;
       min-width: $lg;
       margin: 0;
       color: $inverted-fg;
       border: none;
       background-color: $inverted-bg;
       font-size: $md;
     }
-
-    #sidebar-title img
-    {
-      display: inline-block;
-      height: $sm;
-      vertical-align: middle;
-    }
   }
 
   // align blocks left/right ltr/rtl in navbar
 
   html[dir="ltr"] #sidebar-open,
   html[dir="ltr"] #sidebar-close,
   html[dir="ltr"] #sidebar-logo,
-  html[dir="ltr"] #sidebar-title
+  html[dir="ltr"] #sidebar .site-title
   {
     float: left;
   }
 
   html[dir="rtl"] #sidebar-open,
   html[dir="rtl"] #sidebar-close,
   html[dir="rtl"] #sidebar-logo,
-  html[dir="rtl"] #sidebar-title
+  html[dir="rtl"] #sidebar .site-title
   {
     float: right;
   }
 }
 
 // Primary navigation //////////////////////////////////////////////////////////
 
 #primary-navigation