Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(35)

Issue 29402582: Issue 5098 - Expose FilterStorage initialization state (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 5 months ago by Wladimir Palant
Modified:
2 years, 5 months ago
Reviewers:
kzar
Base URL:
https://hg.adblockplus.org/adblockpluscore
Visibility:
Public.

Description

Issue 5098 - Expose FilterStorage initialization state

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed description #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M lib/filterStorage.js View 3 chunks +9 lines, -0 lines 0 comments Download
M test/filterStorage_readwrite.js View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5
Wladimir Palant
2 years, 5 months ago (2017-04-04 12:51:20 UTC) #1
kzar
Otherwise LGTM https://codereview.adblockplus.org/29402582/diff/29402583/test/filterStorage_readwrite.js File test/filterStorage_readwrite.js (right): https://codereview.adblockplus.org/29402582/diff/29402583/test/filterStorage_readwrite.js#newcode113 test/filterStorage_readwrite.js:113: test.ok(!FilterStorage.initialized, "Not initialize before the first load"); ...
2 years, 5 months ago (2017-04-05 03:51:11 UTC) #2
kzar
On 2017/04/05 03:51:11, kzar wrote: > Nit: Should be "Uninitiated before...". Sorry, I meant "uninitialized".
2 years, 5 months ago (2017-04-05 03:52:13 UTC) #3
Wladimir Palant
https://codereview.adblockplus.org/29402582/diff/29402583/test/filterStorage_readwrite.js File test/filterStorage_readwrite.js (right): https://codereview.adblockplus.org/29402582/diff/29402583/test/filterStorage_readwrite.js#newcode113 test/filterStorage_readwrite.js:113: test.ok(!FilterStorage.initialized, "Not initialize before the first load"); On 2017/04/05 ...
2 years, 5 months ago (2017-04-05 07:16:28 UTC) #4
kzar
2 years, 5 months ago (2017-04-05 10:07:50 UTC) #5
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5