Noissue - Use iterators syntax consistently

compiled/filter/ActiveFilter.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 141 matching lines @@
 {
   auto domains = GetDomains();
   if (!domains || docDomain.empty() || (*domains)[DEFAULT_DOMAIN])
     return false;
 
   docDomain.toLower();
 
   String::size_type len = docDomain.length();
   if (len > 0 && mIgnoreTrailingDot && docDomain[len - 1] == '.')
     docDomain.reset(docDomain, 0, len - 1);
-  for (auto it = domains->begin(); it != domains->end(); ++it)
+  for (const auto& item : *domains)
   {
-    if (!it->second || it->first.equals(docDomain))
+    if (!item.second || item.first.equals(docDomain))
       continue;
 
-    size_t len1 = it->first.length();
+    size_t len1 = item.first.length();
     size_t len2 = docDomain.length();
     if (len1 > len2 &&
-        DependentString(it->first, len1 - len2).equals(docDomain) &&
-        it->first[len1 - len2 - 1] == u'.')
+        DependentString(item.first, len1 - len2).equals(docDomain) &&
+        item.first[len1 - len2 - 1] == u'.')
     {
       continue;
     }
 
     return false;
   }
   return true;
 }
 
 bool ActiveFilter::IsGeneric() const
@@ skipping 16 matching lines @@
     result.append(u'\n');
   }
   if (mLastHit)
   {
     result.append(u"lastHit="_str);
     result.append(to_string(mLastHit));
     result.append(u'\n');
   }
   return result;
 }