Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(390)

Issue 29404594: Noissue - [emscripten] Replace sprintf() usage by safe alternatives (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 10 months ago by Wladimir Palant
Modified:
2 years, 10 months ago
Reviewers:
hub
CC:
Felix Dahlke
Base URL:
https://hg.adblockplus.org/adblockpluscore
Visibility:
Public.

Description

Noissue - [emscripten] Replace sprintf() usage by safe alternatives

Patch Set 1 #

Total comments: 2

Patch Set 2 : Implemented a simple number conversion method #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -19 lines) Patch
M compiled/String.h View 1 2 chunks +31 lines, -1 line 0 comments Download
M compiled/bindings.ipp View 1 1 chunk +4 lines, -5 lines 0 comments Download
M compiled/filter/ActiveFilter.cpp View 1 2 chunks +2 lines, -13 lines 0 comments Download

Messages

Total messages: 4
Wladimir Palant
2 years, 10 months ago (2017-04-06 08:40:25 UTC) #1
hub
important issue. https://codereview.adblockplus.org/29404594/diff/29404595/compiled/filter/ActiveFilter.cpp File compiled/filter/ActiveFilter.cpp (right): https://codereview.adblockplus.org/29404594/diff/29404595/compiled/filter/ActiveFilter.cpp#newcode33 compiled/filter/ActiveFilter.cpp:33: OwnedString result(len); From `man snprintf` > if ...
2 years, 10 months ago (2017-04-06 10:31:23 UTC) #2
Wladimir Palant
Patch set 2 has been rebased and applies to current repository state. https://codereview.adblockplus.org/29404594/diff/29404595/compiled/filter/ActiveFilter.cpp File compiled/filter/ActiveFilter.cpp ...
2 years, 10 months ago (2017-04-06 15:14:40 UTC) #3
hub
2 years, 10 months ago (2017-04-06 16:08:02 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5