Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: include/AdblockPlus/FilterEngine.h

Issue 29405555: Noissue - updated to libadblockplus revision 139ae7a5e3ca (Closed)
Patch Set: Created April 7, 2017, 6:26 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « android_x86/libv8_snapshot.a ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/AdblockPlus/FilterEngine.h
diff --git a/include/AdblockPlus/FilterEngine.h b/include/AdblockPlus/FilterEngine.h
index 3d1df9f5fa9a17ab60178455a6c92889edfed15f..f1ec12ecf378aaa958c34f8f7d1ee8b66c6ede9b 100644
--- a/include/AdblockPlus/FilterEngine.h
+++ b/include/AdblockPlus/FilterEngine.h
@@ -119,6 +119,12 @@ namespace AdblockPlus
*/
bool IsUpdating() const;
+ /**
+ * Indicates whether the subscription is acceptable ads subscription.
+ * @return `true` if this subscription is acceptable ads subscription.
diegocarloslima 2017/04/07 08:45:24 maybe these should be replaced to 'is an acceptabl
diegocarloslima 2017/04/07 08:48:30 Actually, it should be 'is the Acceptable Ads subs
+ */
+ bool IsAA() const;
+
bool operator==(const Subscription& subscription) const;
/**
@@ -307,6 +313,31 @@ namespace AdblockPlus
std::vector<SubscriptionPtr> FetchAvailableSubscriptions() const;
/**
+ * Ensures that Acceptable Ads subscription is enabled or disabled.
+ * @param enabled
+ * - if the value is `true`
+ * - ensure that the filter set includes an enabled AA subscription,
+ * adding it if needed and enabling it if disabled.
+ * - if the value is `false`
+ * - if an AA subscription is present, disable it.
+ * - if absent, do nothing.
+ */
+ void SetAAEnabled(bool enabled);
+
+ /**
+ * Checks whether Acceptable Ads subscription is enabled.
diegocarloslima 2017/04/07 08:45:24 I think it should be either 'whether an Acceptable
diegocarloslima 2017/04/07 08:48:30 Actually, it should be 'whether the Acceptable Ads
+ * @return `true` if acceptable ads subscription is present and enabled.
+ */
+ bool IsAAEnabled() const;
+
+ /**
+ * Retrieves the URL of Acceptable Ads subscription, what makes the URL
+ * available even if subscription is not add yet.
diegocarloslima 2017/04/07 08:45:24 it should be 'is not added yet.'
+ * @return Returns URL of Acceptable Ads.
+ */
+ std::string GetAAUrl() const;
+
+ /**
* Invokes the listener set via SetNotificationAvailableCallback() with the
* next notification to be shown.
* @param url URL to match notifications to (optional).
« no previous file with comments | « android_x86/libv8_snapshot.a ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld