Issue 5121 - Use Acceptable Ads API in libadblockplus

libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/FilterEngineTest.java

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 package org.adblockplus.libadblockplus.tests;
 
-import android.util.Log;
 import org.adblockplus.libadblockplus.Filter;
 import org.adblockplus.libadblockplus.FilterEngine;
 import org.adblockplus.libadblockplus.MockFilterChangeCallback;
 import org.adblockplus.libadblockplus.Subscription;
 
 import org.junit.Test;
 
+import java.util.List;
+
 public class FilterEngineTest extends FilterEngineGenericTest
 {
   @Test
   public void testFilterCreation()
   {
     Filter filter1 = filterEngine.getFilter("foo");
     assertEquals(Filter.Type.BLOCKING, filter1.getType());
     Filter filter2 = filterEngine.getFilter("@@foo");
     assertEquals(Filter.Type.EXCEPTION, filter2.getType());
     Filter filter3 = filterEngine.getFilter("example.com##foo");
@@ skipping 340 matching lines @@
     assertFalse(filterEngine.isElemhideWhitelisted("http://example.co.uk", emptyArray));
     assertFalse(filterEngine.isElemhideWhitelisted("http://example.com", emptyArray));
 
     String[] documentUrls1 = new String[]
       {
         "http://example.de"
       };
     assertTrue(filterEngine.isElemhideWhitelisted("http://example.com", documentUrls1));
     assertFalse(filterEngine.isElemhideWhitelisted("http://example.co.uk", documentUrls1));
   }
+
+  @Test
+  public void testGetAcceptableAdsSubscriptionUrl()
+  {
+    String url = filterEngine.getAcceptableAdsSubscriptionURL();
+    assertNotNull(url);
+  }
+
+  @Test
+  public void testSetGetAcceptableAds()
+  {
+    boolean isAA = filterEngine.isAcceptableAdsEnabled();
+    isAA = !isAA;
+    filterEngine.setAcceptableAdsEnabled(isAA);
+    assertEquals(isAA, filterEngine.isAcceptableAdsEnabled());
+    isAA = !isAA;
+    filterEngine.setAcceptableAdsEnabled(isAA);
+    assertEquals(isAA, filterEngine.isAcceptableAdsEnabled());
+  }
+
+  @Test
+  public void testIsAcceptableAdsIfEnabled()
+  {
+    // `.setAcceptableAdsEnabled(true)` is not required, as we're having
+    // AA subscription listed even if AA is disabled with `filterEngine.setAcceptableAdsEnabled(false);`

[sergei, 2017/04/07 10:22:39]

If there is no AA then `filterEngine.setAcceptableAdsEnabled(false);` won't add
it, so setAcceptableAdsEnabled(true) is required.

The matrix of behavior is here
https://github.com/adblockplus/libadblockplus/blob/master/test/FilterEngine.c....

[diegocarloslima, 2017/04/27 13:32:01]

I think this comment should be removed, since as sergei said, if AA subscription
is not currently present, it won't be added without calling
setAcceptableAdsEnabled(true)

[anton, 2017/04/28 06:21:36]

Done. See updated patch set

+    if (!filterEngine.isAcceptableAdsEnabled())
+    {
+      filterEngine.setAcceptableAdsEnabled(true);
+    }
+    assertTrue(filterEngine.isAcceptableAdsEnabled());
+
+    List<Subscription> listedSubscriptions = filterEngine.getListedSubscriptions();
+    for (Subscription eachSubscription : listedSubscriptions)
+    {
+      if (eachSubscription.isAcceptableAds())
+      {
+        return;
+      }
+    }
+    fail("AA subscription not found in listed subscriptions when enabled");
+  }
 }