Issue 5121 - Use Acceptable Ads API in libadblockplus

libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/FilterEngineTest.java

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 407 matching lines @@
     List<Subscription> listedSubscriptions = filterEngine.getListedSubscriptions();
     for (Subscription eachSubscription : listedSubscriptions)
     {
       if (eachSubscription.isAcceptableAds())
       {
         return;
       }
     }
     fail("AA subscription not found in listed subscriptions when enabled");
   }
-
-  @Test
-  public void testIsAcceptableAdsIfDisabled()
-  {
-    if (filterEngine.isAcceptableAdsEnabled())
-    {
-      filterEngine.setAcceptableAdsEnabled(false);
-    }
-    assertFalse(filterEngine.isAcceptableAdsEnabled());
-
-    List<Subscription> listedSubscriptions = filterEngine.getListedSubscriptions();
-    for (Subscription eachSubscription : listedSubscriptions)
-    {
-      if (eachSubscription.isAcceptableAds())
-      {
-        fail("AA subscription found in listed subscriptions when disabled");

[anton, 2017/04/07 07:08:17]

for some reason the test fails for now

[sergei, 2017/04/07 08:01:22]

You need to also check whether it's disabled. The subscription is present but
it's disabled.
https://github.com/adblockplus/libadblockplus/blob/a1572a509ce45074988b823842...

[anton, 2017/04/07 08:06:49]

there is (and there were) no 'disabled' property in android API:
https://hg.adblockplus.org/libadblockplus-android/file/tip/libadblockplus-and...

what's the purpose of having disabled subscription in the result list of
'getListedSubscriptions()' ?

[sergei, 2017/04/07 09:51:03]

Actually it's a good point, I think we need either Subscription::IsDisabled or
Subscription::IsEnabled because subscription object does have it,
https://issues.adblockplus.org/ticket/5123.
I think there are several reasons for it, a couple of them are that we have such
functionality in browser extensions, a user can add subscriptions and afterwards
disable some of them or enable again (for instance, I personally use that
functionality), so we need to provide others with API enabling them to implement
such functionality in their products based on libadblockplus. Another reason is
that `GetListedSubscriptions` "Retrieves all subscriptions.". I would not like
to change the latter for present because I'm afraid that filtering AA out the
result can break the way AA is used in other products based on libadblockplus.
Actually, since libadblockplus is supposed to be merely a bindings to
adblockpluscore, I would propose to rather file an issue with moving of
`setAASubscriptionEnabled`, `getListedSubscriptions` and other more or less
complicated methods into core and discuss the API there.

-      }
-    }
-  }
 }