Issue 5121 - Use Acceptable Ads API in libadblockplus

libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/FilterEngineTest.java

Index: libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/FilterEngineTest.java
diff --git a/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/FilterEngineTest.java b/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/FilterEngineTest.java
index 23952b6201679804d9b05910abbd033db0817edf..16dd10083857a9c1390249096b01e4a839e2a5a3 100644
--- a/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/FilterEngineTest.java
+++ b/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/FilterEngineTest.java
@@ -17,7 +17,6 @@
 
 package org.adblockplus.libadblockplus.tests;
 
-import android.util.Log;
 import org.adblockplus.libadblockplus.Filter;
 import org.adblockplus.libadblockplus.FilterEngine;
 import org.adblockplus.libadblockplus.MockFilterChangeCallback;
@@ -25,6 +24,8 @@ import org.adblockplus.libadblockplus.Subscription;
 
 import org.junit.Test;
 
+import java.util.List;
+
 public class FilterEngineTest extends FilterEngineGenericTest
 {
   @Test
@@ -385,4 +386,62 @@ public class FilterEngineTest extends FilterEngineGenericTest
     assertTrue(filterEngine.isElemhideWhitelisted("http://example.com", documentUrls1));
     assertFalse(filterEngine.isElemhideWhitelisted("http://example.co.uk", documentUrls1));
   }
+
+  @Test
+  public void testGetAcceptableAdsSubscriptionUrl()
+  {
+    String url = filterEngine.getAcceptableAdsSubscriptionURL();
+    assertNotNull(url);
+  }
+
+  @Test
+  public void testSetGetAcceptableAds()
+  {
+    boolean isAA = filterEngine.isAcceptableAdsEnabled();
+    isAA = !isAA;
+    filterEngine.setAcceptableAdsEnabled(isAA);
+    assertEquals(isAA, filterEngine.isAcceptableAdsEnabled());
+    isAA = !isAA;
+    filterEngine.setAcceptableAdsEnabled(isAA);
+    assertEquals(isAA, filterEngine.isAcceptableAdsEnabled());
+  }
+
+  @Test
+  public void testIsAcceptableAdsIfEnabled()
+  {
+    if (!filterEngine.isAcceptableAdsEnabled())
+    {
+      filterEngine.setAcceptableAdsEnabled(true);
+    }
+    assertTrue(filterEngine.isAcceptableAdsEnabled());
+
+    List<Subscription> listedSubscriptions = filterEngine.getListedSubscriptions();
+    for (Subscription eachSubscription : listedSubscriptions)
+    {
+      if (eachSubscription.isAcceptableAds())
+      {
+        return;
+      }
+    }
+    fail("AA subscription not found in listed subscriptions when enabled");
+  }
+
+  @Test
+  public void testIsAcceptableAdsIfDisabled()
+  {
+    if (filterEngine.isAcceptableAdsEnabled())
+    {
+      filterEngine.setAcceptableAdsEnabled(false);
+    }
+    assertFalse(filterEngine.isAcceptableAdsEnabled());
+
+    List<Subscription> listedSubscriptions = filterEngine.getListedSubscriptions();
+    for (Subscription eachSubscription : listedSubscriptions)
+    {
+      if (eachSubscription.isAcceptableAds())
+      {
+        fail("AA subscription found in listed subscriptions when disabled");

[anton, 2017/04/07 07:08:17]

for some reason the test fails for now

[sergei, 2017/04/07 08:01:22]

You need to also check whether it's disabled. The subscription is present but
it's disabled.
https://github.com/adblockplus/libadblockplus/blob/a1572a509ce45074988b823842...

[anton, 2017/04/07 08:06:49]

there is (and there were) no 'disabled' property in android API:
https://hg.adblockplus.org/libadblockplus-android/file/tip/libadblockplus-and...

what's the purpose of having disabled subscription in the result list of
'getListedSubscriptions()' ?

[sergei, 2017/04/07 09:51:03]

Actually it's a good point, I think we need either Subscription::IsDisabled or
Subscription::IsEnabled because subscription object does have it,
https://issues.adblockplus.org/ticket/5123.
I think there are several reasons for it, a couple of them are that we have such
functionality in browser extensions, a user can add subscriptions and afterwards
disable some of them or enable again (for instance, I personally use that
functionality), so we need to provide others with API enabling them to implement
such functionality in their products based on libadblockplus. Another reason is
that `GetListedSubscriptions` "Retrieves all subscriptions.". I would not like
to change the latter for present because I'm afraid that filtering AA out the
result can break the way AA is used in other products based on libadblockplus.
Actually, since libadblockplus is supposed to be merely a bindings to
adblockpluscore, I would propose to rather file an issue with moving of
`setAASubscriptionEnabled`, `getListedSubscriptions` and other more or less
complicated methods into core and discuss the API there.

+      }
+    }
+  }
 }