Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29405623: Noissue - Make it possible to run the patchconv script without installing it (Closed)

Created:
April 7, 2017, 10:18 a.m. by Vasily Kuznetsov
Modified:
April 7, 2017, 1:43 p.m.
Reviewers:
Sebastian Noack
Visibility:
Public.

Description

Noissue - Make it possible to run the patchconv script without installing it Repository: https://hg.adblockplus.org/codingtools/ Base revision: 003715486580

Patch Set 1 #

Patch Set 2 : Make the script executable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M patchconv/patchconv.py View 1 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 4
Vasily Kuznetsov
I guess it might also make sense to make the script executable. What do you ...
April 7, 2017, 10:23 a.m. (2017-04-07 10:23:55 UTC) #1
Sebastian Noack
LGTM!
April 7, 2017, 10:24 a.m. (2017-04-07 10:24:37 UTC) #2
Vasily Kuznetsov
On 2017/04/07 10:24:37, Sebastian Noack wrote: > LGTM! Rietveld is not very helpful with displaying ...
April 7, 2017, 10:36 a.m. (2017-04-07 10:36:51 UTC) #3
Sebastian Noack
April 7, 2017, 10:44 a.m. (2017-04-07 10:44:03 UTC) #4
Even more LGTM

Powered by Google App Engine
This is Rietveld