Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29408710: Issue 5050 - Make legacy extension use WebExtensions I/O (Closed)

Created:
April 10, 2017, 11:23 a.m. by Wladimir Palant
Modified:
April 11, 2017, 10:25 a.m.
Reviewers:
Sebastian Noack
Base URL:
https://hg.adblockplus.org/adblockplus
Visibility:
Public.

Description

Issue 5050 - Make legacy extension use WebExtensions I/O

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+271 lines, -283 lines) Patch
M chrome/content/ui/utils.js View 1 chunk +1 line, -1 line 1 comment Download
M lib/io.js View 1 chunk +102 lines, -267 lines 1 comment Download
M lib/legacyIO.js View 1 chunk +1 line, -5 lines 0 comments Download
M lib/prefs.json View 1 chunk +0 lines, -1 line 0 comments Download
M lib/utils.js View 1 chunk +1 line, -9 lines 0 comments Download
A webextension/.eslintrc.json View 1 chunk +7 lines, -0 lines 0 comments Download
A webextension/background.js View 1 chunk +41 lines, -0 lines 0 comments Download
A webextension/io.js View 1 chunk +109 lines, -0 lines 2 comments Download
A webextension/manifest.json View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 3
Wladimir Palant
April 10, 2017, 11:23 a.m. (2017-04-10 11:23:14 UTC) #1
Wladimir Palant
https://codereview.adblockplus.org/29408710/diff/29408711/chrome/content/ui/utils.js File chrome/content/ui/utils.js (right): https://codereview.adblockplus.org/29408710/diff/29408711/chrome/content/ui/utils.js#newcode42 chrome/content/ui/utils.js:42: var {IO} = require("legacyIO"); The only real IO usage ...
April 10, 2017, 11:35 a.m. (2017-04-10 11:35:17 UTC) #2
Sebastian Noack
April 10, 2017, 1:43 p.m. (2017-04-10 13:43:23 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld