Issue 5013 - Mark more method as const

src/JsEngine.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 108 matching lines @@
   JsConstValueList callbackArgs;
   for (int i = 2; i < timerTaskIterator->arguments.size(); i++)
     callbackArgs.emplace_back(new JsValue(shared_from_this(),
     v8::Local<v8::Value>::New(GetIsolate(), *timerTaskIterator->arguments[i])));
   callback.Call(callbackArgs);
   timerTasks.erase(timerTaskIterator);
 }
 
 AdblockPlus::JsEngine::JsEngine(const ScopedV8IsolatePtr& isolate, TimerPtr timer)
   : isolate(isolate)
+  , fileSystem(new DefaultFileSystem())
+  , webRequest(new DefaultWebRequest())
+  , logSystem(new DefaultLogSystem())
   , timer(std::move(timer))
 {
 }
 
 AdblockPlus::JsEnginePtr AdblockPlus::JsEngine::New(const AppInfo& appInfo,
   TimerPtr timer,
   const ScopedV8IsolatePtr& isolate)
 {
   JsEnginePtr result(new JsEngine(isolate, std::move(timer)));
 
@@ skipping 116 matching lines @@
 
 AdblockPlus::JsValueList AdblockPlus::JsEngine::ConvertArguments(const v8::Arguments& arguments)
 {
   const JsContext context(shared_from_this());
   JsValueList list;
   for (int i = 0; i < arguments.Length(); i++)
     list.push_back(JsValuePtr(new JsValue(shared_from_this(), arguments[i])));
   return list;
 }
 
-AdblockPlus::FileSystemPtr AdblockPlus::JsEngine::GetFileSystem()
+AdblockPlus::FileSystemPtr AdblockPlus::JsEngine::GetFileSystem() const
 {
-  if (!fileSystem)
-    fileSystem.reset(new DefaultFileSystem());
   return fileSystem;
 }
 
 void AdblockPlus::JsEngine::SetFileSystem(AdblockPlus::FileSystemPtr val)
 {
   if (!val)
     throw std::runtime_error("FileSystem cannot be null");
 
   fileSystem = val;
 }
 
-AdblockPlus::WebRequestPtr AdblockPlus::JsEngine::GetWebRequest()
+AdblockPlus::WebRequestPtr AdblockPlus::JsEngine::GetWebRequest() const
 {
-  if (!webRequest)
-    webRequest.reset(new DefaultWebRequest());
   return webRequest;
 }
 
 void AdblockPlus::JsEngine::SetWebRequest(AdblockPlus::WebRequestPtr val)
 {
   if (!val)
     throw std::runtime_error("WebRequest cannot be null");
 
   webRequest = val;
 }
 
 void AdblockPlus::JsEngine::SetIsConnectionAllowedCallback(const IsConnectionAllowedCallback& callback)
 {
   std::lock_guard<std::mutex> lock(isConnectionAllowedMutex);
   isConnectionAllowed = callback;
 }
 
-bool AdblockPlus::JsEngine::IsConnectionAllowed()
+bool AdblockPlus::JsEngine::IsConnectionAllowed() const
 {
   // The call of isConnectionAllowed can be very expensive and it makes a
   // little sense to block execution of JavaScript for it. Currently this
   // method is called from a thread of web request, so let only this thread be
   // blocked by the call of the callback.
   IsConnectionAllowedCallback localCopy;
   {
     std::lock_guard<std::mutex> lock(isConnectionAllowedMutex);
     localCopy = isConnectionAllowed;
   }
   return !localCopy || localCopy();
 }
 
-AdblockPlus::LogSystemPtr AdblockPlus::JsEngine::GetLogSystem()
+AdblockPlus::LogSystemPtr AdblockPlus::JsEngine::GetLogSystem() const
 {
-  if (!logSystem)
-    logSystem.reset(new DefaultLogSystem());
   return logSystem;
 }
 
 void AdblockPlus::JsEngine::SetLogSystem(AdblockPlus::LogSystemPtr val)
 {
   if (!val)
     throw std::runtime_error("LogSystem cannot be null");
 
   logSystem = val;
 }
 
 
-void AdblockPlus::JsEngine::SetGlobalProperty(const std::string& name, 
+void AdblockPlus::JsEngine::SetGlobalProperty(const std::string& name,
                                               AdblockPlus::JsValuePtr value)
 {
   auto global = GetGlobalObject();
   if (!global)
     throw std::runtime_error("Global object cannot be null");
   global->SetProperty(name, value);
 }