Issue 5013 - Mark more method as const

include/AdblockPlus/JsEngine.h

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 47 matching lines @@
 
   /**
    * Scope based isolate manager. Creates a new isolate instance on
    * constructing and disposes it on destructing.
    */
   class ScopedV8Isolate
   {
   public:
     ScopedV8Isolate();
     ~ScopedV8Isolate();
-    v8::Isolate* Get() const

[sergei, 2017/04/11 10:36:50]

I would like to not make this one and one below const because of the reason
marked as bold in the issue description.

[hub, 2017/04/11 11:32:35]

same for JsEngine::GetIsolate() then?

+    v8::Isolate* Get()
     {
       return isolate;
     }
   private:
     ScopedV8Isolate(const ScopedV8Isolate&);
     ScopedV8Isolate& operator=(const ScopedV8Isolate&);
 
     v8::Isolate* isolate;
   };
 
@@ skipping 196 matching lines @@
     /**
      * Sets a global property that can be accessed by all the scripts.
      * @param name Name of the property to set.
      * @param value Value of the property to set.
      */
     void SetGlobalProperty(const std::string& name, AdblockPlus::JsValuePtr value);
 
     /**
      * Returns a pointer to associated v8::Isolate.
      */
-    v8::Isolate* GetIsolate() const
+    v8::Isolate* GetIsolate()
     {
       return isolate->Get();
     }
 
   private:
     struct TimerTask
     {
       ~TimerTask();
       std::vector<std::unique_ptr<v8::Persistent<v8::Value>>> arguments;
     };
@@ skipping 15 matching lines @@
     EventMap eventCallbacks;
     std::mutex eventCallbacksMutex;
     mutable std::mutex isConnectionAllowedMutex;
     IsConnectionAllowedCallback isConnectionAllowed;
     TimerTasks timerTasks;
     TimerPtr timer;
   };
 }
 
 #endif