Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: include/AdblockPlus/FilterEngine.h

Issue 29408747: Issue 5013 - Mark more method as const (Closed) Base URL: https://hg.adblockplus.org/libadblockplus/
Patch Set: Isolate::Get() and JsEngine::GetIsolate() should be non-const Created April 11, 2017, 11:39 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | include/AdblockPlus/JsEngine.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/AdblockPlus/FilterEngine.h
===================================================================
--- a/include/AdblockPlus/FilterEngine.h
+++ b/include/AdblockPlus/FilterEngine.h
@@ -337,17 +337,17 @@
*/
std::string GetAAUrl() const;
/**
* Invokes the listener set via SetNotificationAvailableCallback() with the
* next notification to be shown.
* @param url URL to match notifications to (optional).
*/
- void ShowNextNotification(const std::string& url = std::string());
+ void ShowNextNotification(const std::string& url = std::string()) const;
/**
* Sets the callback invoked when a notification should be shown.
* @param callback Callback to invoke.
*/
void SetShowNotificationCallback(const ShowNotificationCallback& value);
/**
@@ -529,22 +529,22 @@
int updateCheckId;
static const std::map<ContentType, std::string> contentTypes;
explicit FilterEngine(const JsEnginePtr& jsEngine);
FilterPtr CheckFilterMatch(const std::string& url,
ContentTypeMask contentTypeMask,
const std::string& documentUrl) const;
- void UpdateAvailable(UpdateAvailableCallback callback, JsValueList& params);
+ void UpdateAvailable(UpdateAvailableCallback callback, JsValueList& params) const;
void UpdateCheckDone(const std::string& eventName,
UpdateCheckDoneCallback callback, JsValueList& params);
- void FilterChanged(FilterChangeCallback callback, JsValueList& params);
+ void FilterChanged(FilterChangeCallback callback, JsValueList& params) const;
void ShowNotification(const ShowNotificationCallback& callback,
- const JsValueList& params);
+ const JsValueList& params) const;
FilterPtr GetWhitelistingFilter(const std::string& url,
ContentTypeMask contentTypeMask, const std::string& documentUrl) const;
FilterPtr GetWhitelistingFilter(const std::string& url,
ContentTypeMask contentTypeMask,
const std::vector<std::string>& documentUrls) const;
};
}
« no previous file with comments | « no previous file | include/AdblockPlus/JsEngine.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld