Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29409555: Issue 5083 - Fix metadata regression introduced in previous patch set (Closed)

Created:
April 11, 2017, 5:27 a.m. by Jon Sonesen
Modified:
April 24, 2017, 7:19 a.m.
Reviewers:
Sebastian Noack
CC:
kzar
Base URL:
https://hg.adblockplus.org/adblockpluschrome
Visibility:
Public.

Description

Issue 5083 - Fix metadata regression introduced in previous patch set

Patch Set 1 #

Total comments: 2

Patch Set 2 : removed pointless module reordering #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M metadata.chrome View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
Jon Sonesen
April 11, 2017, 5:27 a.m. (2017-04-11 05:27:39 UTC) #1
Jon Sonesen
It seems that the problem was with the way the metadata ws ordered. I am ...
April 11, 2017, 5:44 a.m. (2017-04-11 05:44:10 UTC) #2
Sebastian Noack
https://codereview.adblockplus.org/29409555/diff/29409556/metadata.chrome File metadata.chrome (right): https://codereview.adblockplus.org/29409555/diff/29409556/metadata.chrome#newcode116 metadata.chrome:116: lib/adblockplus.js += Why not just put them at the ...
April 11, 2017, 8:22 a.m. (2017-04-11 08:22:20 UTC) #3
jsonesen
https://codereview.adblockplus.org/29409555/diff/29409556/metadata.chrome File metadata.chrome (right): https://codereview.adblockplus.org/29409555/diff/29409556/metadata.chrome#newcode116 metadata.chrome:116: lib/adblockplus.js += On 2017/04/11 08:22:19, Sebastian Noack wrote: > ...
April 11, 2017, 9:06 a.m. (2017-04-11 09:06:04 UTC) #4
Sebastian Noack
April 11, 2017, 9:11 a.m. (2017-04-11 09:11:57 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld