Issue 5083 - Fix metadata regression introduced in previous patch set

metadata.chrome

Index: metadata.chrome
===================================================================
--- a/metadata.chrome
+++ b/metadata.chrome
@@ -10,21 +10,21 @@
   contextMenus
   webRequest
   webRequestBlocking
   webNavigation
   storage
   unlimitedStorage
   notifications
 backgroundScripts = ext/common.js
+  ext/background.js
   lib/compat.js
   lib/publicSuffixList.js
   lib/adblockplus.js
   messageResponder.js
-  ext/background.js
   background.js
 testScripts = ../ext/common.js
   ../ext/background.js
   ../lib/compat.js
   ../lib/adblockplus.js
   ../lib/publicSuffixList.js
   common.js
   tests/prefs.js
@@ -85,20 +85,16 @@
   lib/punycode.js
   lib/requestBlocker.js
   lib/stats.js
   lib/subscriptionInit.js
   lib/tldjs.js
   lib/url.js
   lib/utils.js
   lib/whitelisting.js
-  lib/devtools.js
-  lib/popupBlocker.js
-  lib/uninstall.js
-  lib/csp.js
   adblockpluscore/lib/coreUtils.js
   adblockpluscore/lib/common.js
   adblockpluscore/lib/downloader.js
   adblockpluscore/lib/elemHide.js
   adblockpluscore/lib/elemHideEmulation.js
   adblockpluscore/lib/events.js
   adblockpluscore/lib/filterClasses.js
   adblockpluscore/lib/filterListener.js
@@ -112,16 +108,21 @@
   adblockpluscore/lib/subscriptionClasses.js
   adblockpluscore/lib/synchronizer.js
   adblockplusui/lib/antiadblockInit.js
 lib/adblockplus.js[module] = true
 lib/adblockplus.js[injectinfomodule] = true
 lib/adblockplus.js[autoload] = filterListener,synchronizer,requestBlocker,popupBlocker,subscriptionInit,filterComposer,stats,uninstall,csp
 include.postload.js = subscriptionLink.postload.js composer.postload.js
 elemHideEmulation.js = adblockpluscore/lib/common.js adblockpluscore/chrome/content/elemHideEmulation.js
+lib/adblockplus.js += 

[Sebastian Noack, 2017/04/11 08:22:19]

Why not just put them at the bottom of the list above?

  module.js = a.js b.js c.js

is essentially the same as:

  module.js = a.js b.js
  module.js += c.js

The latter syntax merely exist, so that you can append to a list that was
initially defined in a metadata file inherited from.

Moreover, I wonder why the order even matters here? The modules are executed in
the order they are imported anyway, in order to avoid issues like this. The
problem with ext/background.js is different since it is not a module, but are
you sure that the changing the order of the modules here is necessary?

[jsonesen, 2017/04/11 09:06:04]

My bad, I thought last night when testing that I checked whether or not they
were required here and found they were. As discussed In IRC I was mistaken. Will
fix.

+  lib/devtools.js
+  lib/popupBlocker.js
+  lib/uninstall.js
+  lib/csp.js
 
 [import_locales]
 adblockplus/chrome/locale/*/global.properties = subscription_invalid_location
   remove_subscription_warning
   =notification_antiadblock_title
   =notification_antiadblock_message
   filter_unknown_option
   filter_invalid_regexp