Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29409563: Issue 4367 - Updates eyeo address in template (Closed)

Created:
April 11, 2017, 9:30 a.m. by Jon Sonesen
Modified:
April 19, 2017, 9:54 a.m.
Visibility:
Public.

Description

Issue 4367 - Updates eyeo address in template

Patch Set 1 #

Total comments: 2

Patch Set 2 : add managing driectors fix and change edgge verification mail template #

Patch Set 3 : fix missing house number in mail template #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M sitescripts/send_installation_link/template/adblockbrowser_installation_link.tmpl View 1 1 chunk +4 lines, -4 lines 0 comments Download
M sitescripts/submit_email/template/edge_verification.mail View 1 2 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7
Jon Sonesen
April 11, 2017, 9:30 a.m. (2017-04-11 09:30:31 UTC) #1
jsonesen
The issue says two templates, yet I only saw one.
April 11, 2017, 9:30 a.m. (2017-04-11 09:30:47 UTC) #2
Vasily Kuznetsov
Hey Jon, It's funny that with all the discussion in the ticket nobody has noticed ...
April 11, 2017, 10:25 a.m. (2017-04-11 10:25:05 UTC) #3
Vasily Kuznetsov
Actually there's also this one: sitescripts/submit_email/template/edge_verification.mail
April 11, 2017, 10:30 a.m. (2017-04-11 10:30:34 UTC) #4
jsonesen
On 2017/04/11 10:30:34, Vasily Kuznetsov wrote: > Actually there's also this one: > sitescripts/submit_email/template/edge_verification.mail Good ...
April 11, 2017, 11:04 a.m. (2017-04-11 11:04:25 UTC) #5
jsonesen
https://codereview.adblockplus.org/29409563/diff/29409564/sitescripts/send_installation_link/template/adblockbrowser_installation_link.tmpl File sitescripts/send_installation_link/template/adblockbrowser_installation_link.tmpl (left): https://codereview.adblockplus.org/29409563/diff/29409564/sitescripts/send_installation_link/template/adblockbrowser_installation_link.tmpl#oldcode34 sitescripts/send_installation_link/template/adblockbrowser_installation_link.tmpl:34: Managing Directors: Wladimir Palant & Till Faida On 2017/04/11 ...
April 11, 2017, 11:04 a.m. (2017-04-11 11:04:29 UTC) #6
Vasily Kuznetsov
April 11, 2017, 11:14 a.m. (2017-04-11 11:14:36 UTC) #7
On 2017/04/11 11:04:29, jsonesen wrote:
>
https://codereview.adblockplus.org/29409563/diff/29409564/sitescripts/send_in...
> File
>
sitescripts/send_installation_link/template/adblockbrowser_installation_link.tmpl
> (left):
> 
>
https://codereview.adblockplus.org/29409563/diff/29409564/sitescripts/send_in...
>
sitescripts/send_installation_link/template/adblockbrowser_installation_link.tmpl:34:
> Managing Directors: Wladimir Palant & Till Faida
> On 2017/04/11 10:25:05, Vasily Kuznetsov wrote:
> > This line should be also changed to:
> > 
> > Managing Directors: Till Faida, Felix Dahlke, Steffen Kiedel
> 
> Done.

LGTM

Powered by Google App Engine
This is Rietveld