Issue 5013 - Make parameter const ref when applicable.

src/Utils.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 #include <sstream>
 #include <stdexcept>
 
 #ifdef _WIN32
 #include <Windows.h>
 #include <Shlwapi.h>
 #endif
 
 #include "Utils.h"
 
 using namespace AdblockPlus;
 
-std::string Utils::Slurp(std::istream& stream)
+std::string Utils::Slurp(const std::istream& stream)

[sergei, 2017/04/12 13:34:30]

I would like to avoid having const here because we actually modify the stream
object, we get a non-const pointer to basic_stringbuf and modify it.

 {
   std::stringstream content;
   content << stream.rdbuf();
   return content.str();
 }
 
-std::string Utils::FromV8String(v8::Handle<v8::Value> value)
+std::string Utils::FromV8String(const v8::Handle<v8::Value>& value)

[sergei, 2017/04/12 13:34:30]

I'm not sure that v8::Handle should be passed by reference because its copy
constructor is merely copying internally held pointer.
It's also in JsError.{h,cpp}.

[sergei, 2017/04/18 14:02:14]

What about it?

[hub, 2017/04/18 16:18:50]

I thought I had replied to this one. My take is that I just avoid the copy
constructor. I'm not supposed to know what the copy constructor does (ie barely
nothing) and passing the argument as const & just make sure we do it the best
(fastest) way.

 {
   v8::String::Utf8Value stringValue(value);
   if (stringValue.length())
     return std::string(*stringValue, stringValue.length());
   else
     return std::string();
 }
 
 v8::Local<v8::String> Utils::ToV8String(v8::Isolate* isolate, const std::string& str)
 {
@@ skipping 49 matching lines @@
     if (FAILED(hr))
     {
       throw std::runtime_error("CanonizeUrl failed\n");
     }
   }
   return canonizedUrl;
 
 }
 #endif