Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: src/WebRequestJsObject.cpp

Issue 29409580: Issue 5013 - Make parameter const ref when applicable. (Closed) Base URL: https://hg.adblockplus.org/libadblockplus/
Patch Set: Created April 11, 2017, 1:58 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2017 eyeo GmbH 3 * Copyright (C) 2006-2017 eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 98 matching lines...) Expand 10 before | Expand all | Expand 10 after
109 using AdblockPlus::Utils::ToV8String; 109 using AdblockPlus::Utils::ToV8String;
110 v8::Isolate* isolate = arguments.GetIsolate(); 110 v8::Isolate* isolate = arguments.GetIsolate();
111 return v8::ThrowException(ToV8String(isolate, e.what())); 111 return v8::ThrowException(ToV8String(isolate, e.what()));
112 } 112 }
113 thread->Start(); 113 thread->Start();
114 return v8::Undefined(); 114 return v8::Undefined();
115 } 115 }
116 } 116 }
117 117
118 AdblockPlus::JsValuePtr AdblockPlus::WebRequestJsObject::Setup( 118 AdblockPlus::JsValuePtr AdblockPlus::WebRequestJsObject::Setup(
119 AdblockPlus::JsEnginePtr jsEngine, AdblockPlus::JsValuePtr obj) 119 const AdblockPlus::JsEnginePtr& jsEngine, const AdblockPlus::JsValuePtr& obj )
120 { 120 {
121 obj->SetProperty("GET", jsEngine->NewCallback(::GETCallback)); 121 obj->SetProperty("GET", jsEngine->NewCallback(::GETCallback));
122 return obj; 122 return obj;
123 } 123 }
OLDNEW
« src/Utils.cpp ('K') | « src/WebRequestJsObject.h ('k') | test/BaseJsTest.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld