Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: src/JsContext.h

Issue 29409580: Issue 5013 - Make parameter const ref when applicable. (Closed) Base URL: https://hg.adblockplus.org/libadblockplus/
Patch Set: the input stream is no longer const. Created April 12, 2017, 3:08 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/GlobalJsObject.cpp ('k') | src/JsContext.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2017 eyeo GmbH 3 * Copyright (C) 2006-2017 eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details. 12 * GNU General Public License for more details.
13 * 13 *
14 * You should have received a copy of the GNU General Public License 14 * You should have received a copy of the GNU General Public License
15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. 15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
16 */ 16 */
17 17
18 #ifndef ADBLOCK_PLUS_JS_CONTEXT_H 18 #ifndef ADBLOCK_PLUS_JS_CONTEXT_H
19 #define ADBLOCK_PLUS_JS_CONTEXT_H 19 #define ADBLOCK_PLUS_JS_CONTEXT_H
20 20
21 #include <v8.h> 21 #include <v8.h>
22 #include <AdblockPlus/JsEngine.h> 22 #include <AdblockPlus/JsEngine.h>
23 23
24 namespace AdblockPlus 24 namespace AdblockPlus
25 { 25 {
26 class JsContext 26 class JsContext
27 { 27 {
28 public: 28 public:
29 explicit JsContext(const JsEnginePtr jsEngine); 29 explicit JsContext(const JsEnginePtr& jsEngine);
30 30
31 v8::Local<v8::Context> GetV8Context() const 31 v8::Local<v8::Context> GetV8Context() const
32 { 32 {
33 return context; 33 return context;
34 } 34 }
35 35
36 private: 36 private:
37 const v8::Locker locker; 37 const v8::Locker locker;
38 const v8::Isolate::Scope isolateScope; 38 const v8::Isolate::Scope isolateScope;
39 const v8::HandleScope handleScope; 39 const v8::HandleScope handleScope;
40 const v8::Local<v8::Context> context; 40 const v8::Local<v8::Context> context;
41 const v8::Context::Scope contextScope; 41 const v8::Context::Scope contextScope;
42 }; 42 };
43 } 43 }
44 44
45 #endif 45 #endif
OLDNEW
« no previous file with comments | « src/GlobalJsObject.cpp ('k') | src/JsContext.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld