Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: include/AdblockPlus/FileSystem.h

Issue 29409580: Issue 5013 - Make parameter const ref when applicable. (Closed) Base URL: https://hg.adblockplus.org/libadblockplus/
Left Patch Set: Created April 11, 2017, 1:58 p.m.
Right Patch Set: the input stream is no longer const. Created April 12, 2017, 3:08 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « include/AdblockPlus/DefaultFileSystem.h ('k') | include/AdblockPlus/FilterEngine.h » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2017 eyeo GmbH 3 * Copyright (C) 2006-2017 eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
74 */ 74 */
75 virtual std::shared_ptr<std::istream> 75 virtual std::shared_ptr<std::istream>
76 Read(const std::string& path) const = 0; 76 Read(const std::string& path) const = 0;
77 77
78 /** 78 /**
79 * Writes to a file. 79 * Writes to a file.
80 * @param path File path. 80 * @param path File path.
81 * @param data Input stream with the data to write. 81 * @param data Input stream with the data to write.
82 */ 82 */
83 virtual void Write(const std::string& path, 83 virtual void Write(const std::string& path,
84 const std::shared_ptr<std::istream>& data) = 0; 84 std::istream& data) = 0;
85 85
86 /** 86 /**
87 * Moves a file (i.e.\ renames it). 87 * Moves a file (i.e.\ renames it).
88 * @param fromPath Current path to the file. 88 * @param fromPath Current path to the file.
89 * @param toPath New path to the file. 89 * @param toPath New path to the file.
90 */ 90 */
91 virtual void Move(const std::string& fromPath, 91 virtual void Move(const std::string& fromPath,
92 const std::string& toPath) = 0; 92 const std::string& toPath) = 0;
93 93
94 /** 94 /**
(...skipping 17 matching lines...) Expand all
112 virtual std::string Resolve(const std::string& path) const = 0; 112 virtual std::string Resolve(const std::string& path) const = 0;
113 }; 113 };
114 114
115 /** 115 /**
116 * Shared smart pointer to a `FileSystem` instance. 116 * Shared smart pointer to a `FileSystem` instance.
117 */ 117 */
118 typedef std::shared_ptr<FileSystem> FileSystemPtr; 118 typedef std::shared_ptr<FileSystem> FileSystemPtr;
119 } 119 }
120 120
121 #endif 121 #endif
LEFTRIGHT

Powered by Google App Engine
This is Rietveld