Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: include/AdblockPlus/FilterEngine.h

Issue 29409580: Issue 5013 - Make parameter const ref when applicable. (Closed) Base URL: https://hg.adblockplus.org/libadblockplus/
Left Patch Set: Created April 11, 2017, 1:58 p.m.
Right Patch Set: the input stream is no longer const. Created April 12, 2017, 3:08 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « include/AdblockPlus/FileSystem.h ('k') | include/AdblockPlus/JsEngine.h » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2017 eyeo GmbH 3 * Copyright (C) 2006-2017 eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 188 matching lines...) Expand 10 before | Expand all | Expand 10 after
199 */ 199 */
200 typedef std::function<void(const std::string&)> UpdateCheckDoneCallback; 200 typedef std::function<void(const std::string&)> UpdateCheckDoneCallback;
201 201
202 /** 202 /**
203 * Callback type invoked when the filters change. 203 * Callback type invoked when the filters change.
204 * The first parameter is the action event code (see 204 * The first parameter is the action event code (see
205 * [FilterNotifier.triggerListeners](https://adblockplus.org/jsdoc/adblockpl uscore/FilterNotifier.html#.triggerListeners) 205 * [FilterNotifier.triggerListeners](https://adblockplus.org/jsdoc/adblockpl uscore/FilterNotifier.html#.triggerListeners)
206 * for the full list). 206 * for the full list).
207 * The second parameter is the filter/subscription object affected, if any. 207 * The second parameter is the filter/subscription object affected, if any.
208 */ 208 */
209 typedef std::function<void(const std::string&, const JsValuePtr&)> FilterCha ngeCallback; 209 typedef std::function<void(const std::string&, const JsValue&)> FilterChange Callback;
210 210
211 /** 211 /**
212 * Container of name-value pairs representing a set of preferences. 212 * Container of name-value pairs representing a set of preferences.
213 */ 213 */
214 typedef std::map<std::string, AdblockPlus::JsValuePtr> Prefs; 214 typedef std::map<std::string, AdblockPlus::JsValuePtr> Prefs;
215 215
216 /** 216 /**
217 * Callback type invoked when a new notification should be shown. 217 * Callback type invoked when a new notification should be shown.
218 * The parameter is the Notification object to be shown. 218 * The parameter is the Notification object to be shown.
219 */ 219 */
(...skipping 322 matching lines...) Expand 10 before | Expand all | Expand 10 after
542 const JsValueList& params) const; 542 const JsValueList& params) const;
543 FilterPtr GetWhitelistingFilter(const std::string& url, 543 FilterPtr GetWhitelistingFilter(const std::string& url,
544 ContentTypeMask contentTypeMask, const std::string& documentUrl) const; 544 ContentTypeMask contentTypeMask, const std::string& documentUrl) const;
545 FilterPtr GetWhitelistingFilter(const std::string& url, 545 FilterPtr GetWhitelistingFilter(const std::string& url,
546 ContentTypeMask contentTypeMask, 546 ContentTypeMask contentTypeMask,
547 const std::vector<std::string>& documentUrls) const; 547 const std::vector<std::string>& documentUrls) const;
548 }; 548 };
549 } 549 }
550 550
551 #endif 551 #endif
LEFTRIGHT

Powered by Google App Engine
This is Rietveld