src/GlobalJsObject.h - Issue 29409580: Issue 5013 - Make parameter const ref when applicable.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: src/GlobalJsObject.h

Issue 29409580: Issue 5013 - Make parameter const ref when applicable. (Closed) Base URL: https://hg.adblockplus.org/libadblockplus/

Left Patch Set: Created April 11, 2017, 1:58 p.m.

Right Patch Set: the input stream is no longer const. Created April 12, 2017, 3:08 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 /*	1 /*

2 * This file is part of Adblock Plus <https://adblockplus.org/>,	2 * This file is part of Adblock Plus <https://adblockplus.org/>,

3 * Copyright (C) 2006-2017 eyeo GmbH	3 * Copyright (C) 2006-2017 eyeo GmbH

4 *	4 *

5 * Adblock Plus is free software: you can redistribute it and/or modify	5 * Adblock Plus is free software: you can redistribute it and/or modify

6 * it under the terms of the GNU General Public License version 3 as	6 * it under the terms of the GNU General Public License version 3 as

7 * published by the Free Software Foundation.	7 * published by the Free Software Foundation.

8 *	8 *

9 * Adblock Plus is distributed in the hope that it will be useful,	9 * Adblock Plus is distributed in the hope that it will be useful,

10 * but WITHOUT ANY WARRANTY; without even the implied warranty of	10 * but WITHOUT ANY WARRANTY; without even the implied warranty of

(...skipping 10 matching lines...) Expand all Loading...
21 #include <v8.h>	21 #include <v8.h>

22 #include <AdblockPlus/JsEngine.h>	22 #include <AdblockPlus/JsEngine.h>

23	23

24 namespace AdblockPlus	24 namespace AdblockPlus

25 {	25 {

26 class AppInfo;	26 class AppInfo;

27 class JsEngine;	27 class JsEngine;

28	28

29 namespace GlobalJsObject	29 namespace GlobalJsObject

30 {	30 {

31 JsValuePtr Setup(const JsEnginePtr& jsEngine, const AppInfo& appInfo, const JsValuePtr& obj);	31 JsValuePtr Setup(JsEngine& jsEngine, const AppInfo& appInfo, const JsValuePt r& obj);

32 }	32 }

33 }	33 }

34	34

35 #endif	35 #endif

LEFT	RIGHT