Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: src/JsEngine.cpp

Issue 29409580: Issue 5013 - Make parameter const ref when applicable. (Closed) Base URL: https://hg.adblockplus.org/libadblockplus/
Left Patch Set: Created April 11, 2017, 1:58 p.m.
Right Patch Set: the input stream is no longer const. Created April 12, 2017, 3:08 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « src/JsContext.cpp ('k') | src/JsError.h » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2017 eyeo GmbH 3 * Copyright (C) 2006-2017 eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 127 matching lines...) Expand 10 before | Expand all | Expand 10 after
138 const ScopedV8IsolatePtr& isolate) 138 const ScopedV8IsolatePtr& isolate)
139 { 139 {
140 JsEnginePtr result(new JsEngine(isolate, std::move(timer))); 140 JsEnginePtr result(new JsEngine(isolate, std::move(timer)));
141 141
142 const v8::Locker locker(result->GetIsolate()); 142 const v8::Locker locker(result->GetIsolate());
143 const v8::Isolate::Scope isolateScope(result->GetIsolate()); 143 const v8::Isolate::Scope isolateScope(result->GetIsolate());
144 const v8::HandleScope handleScope(result->GetIsolate()); 144 const v8::HandleScope handleScope(result->GetIsolate());
145 145
146 result->context.reset(new v8::Persistent<v8::Context>(result->GetIsolate(), 146 result->context.reset(new v8::Persistent<v8::Context>(result->GetIsolate(),
147 v8::Context::New(result->GetIsolate()))); 147 v8::Context::New(result->GetIsolate())));
148 AdblockPlus::GlobalJsObject::Setup(result, appInfo, result->GetGlobalObject()) ; 148 AdblockPlus::GlobalJsObject::Setup(*result, appInfo, result->GetGlobalObject() );
149 return result; 149 return result;
150 } 150 }
151 151
152 AdblockPlus::JsValuePtr AdblockPlus::JsEngine::GetGlobalObject() 152 AdblockPlus::JsValuePtr AdblockPlus::JsEngine::GetGlobalObject()
153 { 153 {
154 JsContext context(shared_from_this()); 154 JsContext context(shared_from_this());
155 return JsValuePtr(new JsValue(shared_from_this(), context.GetV8Context()->Glob al())); 155 return JsValuePtr(new JsValue(shared_from_this(), context.GetV8Context()->Glob al()));
156 } 156 }
157 157
158 AdblockPlus::JsValuePtr AdblockPlus::JsEngine::Evaluate(const std::string& sourc e, 158 AdblockPlus::JsValuePtr AdblockPlus::JsEngine::Evaluate(const std::string& sourc e,
(...skipping 167 matching lines...) Expand 10 before | Expand all | Expand 10 after
326 326
327 327
328 void AdblockPlus::JsEngine::SetGlobalProperty(const std::string& name, 328 void AdblockPlus::JsEngine::SetGlobalProperty(const std::string& name,
329 const AdblockPlus::JsValuePtr& val ue) 329 const AdblockPlus::JsValuePtr& val ue)
330 { 330 {
331 auto global = GetGlobalObject(); 331 auto global = GetGlobalObject();
332 if (!global) 332 if (!global)
333 throw std::runtime_error("Global object cannot be null"); 333 throw std::runtime_error("Global object cannot be null");
334 global->SetProperty(name, value); 334 global->SetProperty(name, value);
335 } 335 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld