Issue 5013 - Make parameter const ref when applicable.

src/WebRequestJsObject.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 11 matching lines @@
 #include "JsContext.h"
 #include "Thread.h"
 #include "Utils.h"
 #include "WebRequestJsObject.h"
 
 namespace
 {
   class WebRequestThread : public AdblockPlus::Thread
   {
   public:
-    WebRequestThread(AdblockPlus::JsEnginePtr jsEngine, AdblockPlus::JsValueList& arguments)
+    WebRequestThread(const AdblockPlus::JsEnginePtr& jsEngine, const AdblockPlus::JsValueList& arguments)
         : Thread(true), jsEngine(jsEngine), url(arguments[0]->AsString())
     {
       if (!url.length())
         throw std::runtime_error("Invalid string passed as first argument to GET");
 
       {
         AdblockPlus::JsValuePtr headersObj = arguments[1];
         if (!headersObj->IsObject())
           throw std::runtime_error("Second argument to GET must be an object");
 
@@ skipping 66 matching lines @@
       using AdblockPlus::Utils::ToV8String;
       v8::Isolate* isolate = arguments.GetIsolate();
       return v8::ThrowException(ToV8String(isolate, e.what()));
     }
     thread->Start();
     return v8::Undefined();
   }
 }
 
 AdblockPlus::JsValuePtr AdblockPlus::WebRequestJsObject::Setup(
-    const AdblockPlus::JsEnginePtr& jsEngine, const AdblockPlus::JsValuePtr& obj)
+    AdblockPlus::JsEngine& jsEngine, const AdblockPlus::JsValuePtr& obj)
 {
-  obj->SetProperty("GET", jsEngine->NewCallback(::GETCallback));
+  obj->SetProperty("GET", jsEngine.NewCallback(::GETCallback));
   return obj;
 }