Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: include/AdblockPlus/FileSystem.h

Issue 29409580: Issue 5013 - Make parameter const ref when applicable. (Closed) Base URL: https://hg.adblockplus.org/libadblockplus/
Patch Set: Created April 11, 2017, 1:58 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: include/AdblockPlus/FileSystem.h
===================================================================
--- a/include/AdblockPlus/FileSystem.h
+++ b/include/AdblockPlus/FileSystem.h
@@ -76,17 +76,17 @@
Read(const std::string& path) const = 0;
/**
* Writes to a file.
* @param path File path.
* @param data Input stream with the data to write.
*/
virtual void Write(const std::string& path,
- std::shared_ptr<std::istream> data) = 0;
+ const std::shared_ptr<std::istream>& data) = 0;
/**
* Moves a file (i.e.\ renames it).
* @param fromPath Current path to the file.
* @param toPath New path to the file.
*/
virtual void Move(const std::string& fromPath,
const std::string& toPath) = 0;

Powered by Google App Engine
This is Rietveld