Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: src/DefaultFileSystem.cpp

Issue 29409580: Issue 5013 - Make parameter const ref when applicable. (Closed) Base URL: https://hg.adblockplus.org/libadblockplus/
Patch Set: Created April 11, 2017, 1:58 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/DefaultFileSystem.cpp
===================================================================
--- a/src/DefaultFileSystem.cpp
+++ b/src/DefaultFileSystem.cpp
@@ -71,17 +71,17 @@
{
std::shared_ptr<std::istream> result(new std::ifstream(NormalizePath(path).c_str()));
if (result->fail())
throw RuntimeErrorWithErrno("Failed to open " + path);
return result;
}
void DefaultFileSystem::Write(const std::string& path,
- std::shared_ptr<std::istream> data)
+ const std::shared_ptr<std::istream>& data)
{
std::ofstream file(NormalizePath(path).c_str(), std::ios_base::out | std::ios_base::binary);
file << Utils::Slurp(*data);
}
void DefaultFileSystem::Move(const std::string& fromPath,
const std::string& toPath)
{

Powered by Google App Engine
This is Rietveld