Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: src/FileSystemJsObject.cpp

Issue 29409580: Issue 5013 - Make parameter const ref when applicable. (Closed) Base URL: https://hg.adblockplus.org/libadblockplus/
Patch Set: Created April 11, 2017, 1:58 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/FileSystemJsObject.cpp
===================================================================
--- a/src/FileSystemJsObject.cpp
+++ b/src/FileSystemJsObject.cpp
@@ -344,17 +344,17 @@
std::string resolved = jsEngine->GetFileSystem()->Resolve(converted[0]->AsString());
return Utils::ToV8String(isolate, resolved);
}
}
-JsValuePtr FileSystemJsObject::Setup(JsEnginePtr jsEngine, JsValuePtr obj)
+JsValuePtr FileSystemJsObject::Setup(const JsEnginePtr& jsEngine, const JsValuePtr& obj)
{
obj->SetProperty("read", jsEngine->NewCallback(::ReadCallback));
obj->SetProperty("write", jsEngine->NewCallback(::WriteCallback));
obj->SetProperty("move", jsEngine->NewCallback(::MoveCallback));
obj->SetProperty("remove", jsEngine->NewCallback(::RemoveCallback));
obj->SetProperty("stat", jsEngine->NewCallback(::StatCallback));
obj->SetProperty("resolve", jsEngine->NewCallback(::ResolveCallback));
return obj;

Powered by Google App Engine
This is Rietveld