Unified Diff: test/BaseJsTest.h
Issue 29409580:
Issue 5013 - Make parameter const ref when applicable. (Closed)
Base URL: https://hg.adblockplus.org/libadblockplus/
Patch Set:
Created April 11, 2017, 1:58 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« src/Utils.cpp ('K')
|
« src/WebRequestJsObject.cpp ('k')
|
test/FileSystemJsObject.cpp » ('j')
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: test/BaseJsTest.h |
| =================================================================== |
| --- a/test/BaseJsTest.h |
| +++ b/test/BaseJsTest.h |
| @@ -35,17 +35,17 @@ |
| class ThrowingFileSystem : public AdblockPlus::FileSystem |
| { |
| public: |
| std::shared_ptr<std::istream> Read(const std::string& path) const |
| { |
| throw std::runtime_error("Not implemented"); |
| } |
| - void Write(const std::string& path, std::shared_ptr<std::istream> content) |
| + void Write(const std::string& path, const std::shared_ptr<std::istream>& content) |
| { |
| throw std::runtime_error("Not implemented"); |
| } |
| void Move(const std::string& fromPath, const std::string& toPath) |
| { |
| throw std::runtime_error("Not implemented"); |
| } |
| @@ -84,17 +84,17 @@ |
| std::string dummyData(""); |
| if (path == "patterns.ini") |
| dummyData = "# Adblock Plus preferences\n[Subscription]\nurl=~fl~"; |
| else if (path == "prefs.json") |
| dummyData = "{}"; |
| return std::shared_ptr<std::istream>(new std::istringstream(dummyData)); |
| } |
| - void Write(const std::string& path, std::shared_ptr<std::istream> content) |
| + void Write(const std::string& path, const std::shared_ptr<std::istream>& content) |
| { |
| } |
| void Move(const std::string& fromPath, const std::string& toPath) |
| { |
| } |
| void Remove(const std::string& path) |
« src/Utils.cpp ('K')
|
« src/WebRequestJsObject.cpp ('k')
|
test/FileSystemJsObject.cpp » ('j')
|
no next file with comments »
