Unified Diff: test/Prefs.cpp
Issue 29409580:
Issue 5013 - Make parameter const ref when applicable. (Closed)
Base URL: https://hg.adblockplus.org/libadblockplus/
Patch Set:
Created April 11, 2017, 1:58 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« src/Utils.cpp ('K')
|
« test/FileSystemJsObject.cpp ('k')
|
test/UpdateCheck.cpp » ('j')
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: test/Prefs.cpp |
| =================================================================== |
| --- a/test/Prefs.cpp |
| +++ b/test/Prefs.cpp |
| @@ -32,17 +32,17 @@ |
| std::shared_ptr<std::istream> Read(const std::string& path) const |
| { |
| if (path == "prefs.json" && !prefsContents.empty()) |
| return std::shared_ptr<std::istream>(new std::istringstream(prefsContents)); |
| return LazyFileSystem::Read(path); |
| } |
| - void Write(const std::string& path, std::shared_ptr<std::istream> content) |
| + void Write(const std::string& path, const std::shared_ptr<std::istream>& content) |
| { |
| if (path == "prefs.json") |
| { |
| std::stringstream ss; |
| ss << content->rdbuf(); |
| prefsContents = ss.str(); |
| } |
| else |
| @@ -199,9 +199,9 @@ |
| ASSERT_FALSE(fileSystem->prefsContents.empty()); |
| jsEngine.reset(); |
| Reset(preconfiguredPrefs); |
| ASSERT_TRUE(filterEngine->GetPref("suppress_first_run_page")->IsBool()); |
| ASSERT_FALSE(filterEngine->GetPref("suppress_first_run_page")->AsBool()); |
| -} |
| +} |
« src/Utils.cpp ('K')
|
« test/FileSystemJsObject.cpp ('k')
|
test/UpdateCheck.cpp » ('j')
|
no next file with comments »
