Unified Diff: src/JsValue.cpp
Issue 29409580:
Issue 5013 - Make parameter const ref when applicable. (Closed)
Base URL: https://hg.adblockplus.org/libadblockplus/
Patch Set: Pass ref or const ref instead of shared_ptr<>
Created April 11, 2017, 3:37 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« src/JsError.cpp ('k')
|
src/Thread.h » ('j')
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: src/JsValue.cpp |
| =================================================================== |
| --- a/src/JsValue.cpp |
| +++ b/src/JsValue.cpp |
| @@ -202,17 +202,17 @@ |
| if (!IsObject()) |
| throw new std::runtime_error("Cannot get constructor of a non-object"); |
| const JsContext context(jsEngine); |
| v8::Local<v8::Object> obj = v8::Local<v8::Object>::Cast(UnwrapValue()); |
| return Utils::FromV8String(obj->GetConstructorName()); |
| } |
| -JsValue JsValue::Call(const JsConstValueList& params, JsValuePtr thisPtr) const |
| +JsValue JsValue::Call(const JsConstValueList& params, const JsValuePtr& thisPtr) const |
| { |
| const JsContext context(jsEngine); |
| v8::Local<v8::Object> thisObj = thisPtr ? |
| v8::Local<v8::Object>::Cast(thisPtr->UnwrapValue()) : |
| context.GetV8Context()->Global(); |
| std::vector<v8::Handle<v8::Value>> argv; |
| for (const auto& param : params) |
« no previous file with comments
|
« src/JsError.cpp ('k')
|
src/Thread.h » ('j')
|
no next file with comments »
