Unified Diff: src/AppInfoJsObject.cpp
Issue 29409580:
Issue 5013 - Make parameter const ref when applicable. (Closed)
Base URL: https://hg.adblockplus.org/libadblockplus/
Patch Set: Remove an unecessary smart pointer.
Created April 11, 2017, 3:46 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« src/AppInfoJsObject.h ('k')
|
src/ConsoleJsObject.h » ('j')
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: src/AppInfoJsObject.cpp |
| =================================================================== |
| --- a/src/AppInfoJsObject.cpp |
| +++ b/src/AppInfoJsObject.cpp |
| @@ -18,18 +18,17 @@ |
| #include <AdblockPlus/AppInfo.h> |
| #include <AdblockPlus/JsValue.h> |
| #include "AppInfoJsObject.h" |
| #include "Utils.h" |
| using namespace AdblockPlus; |
| -JsValuePtr AppInfoJsObject::Setup(JsEnginePtr jsEngine, const AppInfo& appInfo, |
| - JsValuePtr obj) |
| +JsValuePtr AppInfoJsObject::Setup(const AppInfo& appInfo, const JsValuePtr& obj) |
| { |
| obj->SetProperty("version", appInfo.version); |
| obj->SetProperty("name", appInfo.name); |
| obj->SetProperty("application", appInfo.application); |
| obj->SetProperty("applicationVersion", appInfo.applicationVersion); |
| obj->SetProperty("locale", appInfo.locale); |
| obj->SetProperty("developmentBuild", appInfo.developmentBuild); |
| return obj; |
« no previous file with comments
|
« src/AppInfoJsObject.h ('k')
|
src/ConsoleJsObject.h » ('j')
|
no next file with comments »
