src/GlobalJsObject.h - Issue 29409580: Issue 5013 - Make parameter const ref when applicable.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/GlobalJsObject.h

Issue 29409580: Issue 5013 - Make parameter const ref when applicable. (Closed) Base URL: https://hg.adblockplus.org/libadblockplus/

Patch Set: Remove an unecessary smart pointer. Created April 11, 2017, 3:46 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: src/GlobalJsObject.h

===================================================================

--- a/src/GlobalJsObject.h

+++ b/src/GlobalJsObject.h

@@ -23,13 +23,13 @@

namespace AdblockPlus

{

class AppInfo;

class JsEngine;

namespace GlobalJsObject

{

- JsValuePtr Setup(JsEnginePtr jsEngine, const AppInfo& appInfo, JsValuePtr obj);

+ JsValuePtr Setup(JsEngine& jsEngine, const AppInfo& appInfo, const JsValuePtr& obj);

}

#endif

« no previous file with comments | « src/FilterEngine.cpp ('k') | src/GlobalJsObject.cpp » ('j') | no next file with comments »