Issue 5013 - Make parameter const ref when applicable.

src/AppInfoJsObject.cpp

Index: src/AppInfoJsObject.cpp
===================================================================
--- a/src/AppInfoJsObject.cpp
+++ b/src/AppInfoJsObject.cpp
@@ -18,18 +18,17 @@
 #include <AdblockPlus/AppInfo.h>
 #include <AdblockPlus/JsValue.h>
 
 #include "AppInfoJsObject.h"
 #include "Utils.h"
 
 using namespace AdblockPlus;
 
-JsValuePtr AppInfoJsObject::Setup(JsEnginePtr jsEngine, const AppInfo& appInfo,
-    JsValuePtr obj)
+JsValuePtr AppInfoJsObject::Setup(const AppInfo& appInfo, const JsValuePtr& obj)

[sergei, 2017/04/12 13:34:31]

Here and in other *JsObject files it seems it would be better to simply pass
`JsValue&`.

[hub, 2017/04/12 13:51:35]

I have that in another patch. But I can put it in this one of you want.

[sergei, 2017/04/12 13:57:24]

Will it be possible to firstly commit that another patch and then the current
one?

[hub, 2017/04/12 14:04:52]

Actually this need a change to SetProperty to accept a const JsValue& as it
currently want a JsValuePtr. My other patch take care of this, but it is not
simple.
I don't think. I could try though.

[hub, 2017/04/13 08:13:45]

Patch in question to apply after this is up for review.
https://codereview.adblockplus.org/29410664/

 {
   obj->SetProperty("version", appInfo.version);
   obj->SetProperty("name", appInfo.name);
   obj->SetProperty("application", appInfo.application);
   obj->SetProperty("applicationVersion", appInfo.applicationVersion);
   obj->SetProperty("locale", appInfo.locale);
   obj->SetProperty("developmentBuild", appInfo.developmentBuild);
   return obj;