src/GlobalJsObject.cpp - Issue 29409580: Issue 5013 - Make parameter const ref when applicable.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/GlobalJsObject.cpp

Issue 29409580: Issue 5013 - Make parameter const ref when applicable. (Closed) Base URL: https://hg.adblockplus.org/libadblockplus/

Patch Set: Rebased Created April 12, 2017, 8:49 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: src/GlobalJsObject.cpp

===================================================================

--- a/src/GlobalJsObject.cpp

+++ b/src/GlobalJsObject.cpp

@@ -63,23 +63,23 @@

}

std::string eventName = converted.front()->AsString();

converted.erase(converted.begin());

jsEngine->TriggerEvent(eventName, converted);

return v8::Undefined();

}

-JsValuePtr GlobalJsObject::Setup(JsEnginePtr jsEngine, const AppInfo& appInfo,

- JsValuePtr obj)

+JsValuePtr GlobalJsObject::Setup(JsEngine& jsEngine, const AppInfo& appInfo,

+ const JsValuePtr& obj)

{

- obj->SetProperty("setTimeout", jsEngine->NewCallback(::SetTimeoutCallback));

- obj->SetProperty("_triggerEvent", jsEngine->NewCallback(::TriggerEventCallback));

+ obj->SetProperty("setTimeout", jsEngine.NewCallback(::SetTimeoutCallback));

+ obj->SetProperty("_triggerEvent", jsEngine.NewCallback(::TriggerEventCallback));

obj->SetProperty("_fileSystem",

- FileSystemJsObject::Setup(jsEngine, jsEngine->NewObject()));

+ FileSystemJsObject::Setup(jsEngine, jsEngine.NewObject()));

obj->SetProperty("_webRequest",

- WebRequestJsObject::Setup(jsEngine, jsEngine->NewObject()));

+ WebRequestJsObject::Setup(jsEngine, jsEngine.NewObject()));

obj->SetProperty("console",

- ConsoleJsObject::Setup(jsEngine, jsEngine->NewObject()));

+ ConsoleJsObject::Setup(jsEngine, jsEngine.NewObject()));

obj->SetProperty("_appInfo",

- AppInfoJsObject::Setup(jsEngine, appInfo, jsEngine->NewObject()));

+ AppInfoJsObject::Setup(appInfo, jsEngine.NewObject()));

return obj;

}